From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GZ0Sq-000298-UO for qemu-devel@nongnu.org; Sun, 15 Oct 2006 03:31:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GZ0Sp-00028i-Ca for qemu-devel@nongnu.org; Sun, 15 Oct 2006 03:31:16 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GZ0Sp-00028c-7k for qemu-devel@nongnu.org; Sun, 15 Oct 2006 03:31:15 -0400 Received: from [64.233.182.191] (helo=nf-out-0910.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GZ0bf-00028I-Lx for qemu-devel@nongnu.org; Sun, 15 Oct 2006 03:40:23 -0400 Received: by nf-out-0910.google.com with SMTP id p46so2096101nfa for ; Sun, 15 Oct 2006 00:31:11 -0700 (PDT) Message-ID: <92c265230610150031h570a1cfenedc723b9a9949a25@mail.gmail.com> Date: Sun, 15 Oct 2006 15:31:11 +0800 From: Tace Subject: Re: [Qemu-devel] qemu and kernel 2.6.18 In-Reply-To: <20061014094706.a59e3e33.chris@friedhoff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <9b0d5f320610131000x744ce6cagd549f4ec0e1ac9f7@mail.gmail.com> <20061014094706.a59e3e33.chris@friedhoff.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, That might be some security issues with removal of that capability check. I think it is not a good idea to remove it. 2006/10/14, chris friedhoff : > Hello, > > bringing up the tun/tap interface depends now on the capability CAP_NET_ADMIN, which usually only root has. > This patch just removes this dependency, so normal user rights suffices again to bring up the tun/tap interface. > > diff -ruN linux-2.6.18-orig/drivers/net/tun.c linux-2.6.18/drivers/net/tun.c > --- linux-2.6.18-orig/drivers/net/tun.c 2006-09-20 05:42:06.000000000 +0200 > +++ linux-2.6.18/drivers/net/tun.c 2006-10-02 09:21:52.000000000 +0200 > @@ -489,9 +489,6 @@ > > err = -EINVAL; > > - if (!capable(CAP_NET_ADMIN)) > - return -EPERM; > - > /* Set dev type */ > if (ifr->ifr_flags & IFF_TUN) { > /* TUN device */ > > > chris > > ###################################### > > On Fri, 13 Oct 2006 13:00:10 -0400 > WaxDragon wrote: > > > This came up in IRC a few days ago, it seems you need to use the UML > > util 'tunctl' to assign permissions to the tap device. I found this > > change annoying. > > > > On 10/13/06, G Portokalidis wrote: > > > Hello all, > > > I have recently installed the latest linux kernel, and i have been > > > having problems with the tap interface since. > > > > > > I have been getting the following cryptic message: > > > warning: could not configure /dev/net/tun: no virtual network emulation > > > Could not initialize device 'tap' > > > > > > The tun driver is loaded, and /dev/net/tun is 'rw'. > > > Any ideas what this is about? Could i have misconfigured something in > > > the kernel? > > > > > > Cheers, > > > George > > > > > > > > > _______________________________________________ > > > Qemu-devel mailing list > > > Qemu-devel@nongnu.org > > > http://lists.nongnu.org/mailman/listinfo/qemu-devel > > > > > > > > > -- > > 22:38 <@WaxDragon> false ^ true > > 22:39 < false> :( > > 22:39 < false> dont you think you can XOR me and get away with it! I > > always return! > > > > > > _______________________________________________ > > Qemu-devel mailing list > > Qemu-devel@nongnu.org > > http://lists.nongnu.org/mailman/listinfo/qemu-devel > > > -------------------- > Chris Friedhoff > chris@friedhoff.org > > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel > > > >