From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CF2C4741F for ; Thu, 5 Nov 2020 15:40:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B74A420782 for ; Thu, 5 Nov 2020 15:40:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y/o79OJK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B74A420782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kahMq-0006rR-46 for qemu-devel@archiver.kernel.org; Thu, 05 Nov 2020 10:40:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kahME-0006QJ-Sj for qemu-devel@nongnu.org; Thu, 05 Nov 2020 10:39:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kahMC-0003iL-TK for qemu-devel@nongnu.org; Thu, 05 Nov 2020 10:39:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604590764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3fLCt09UHL5vonyTfq6valUwcAl6RlQninwjo9OsfrE=; b=Y/o79OJKkggom6QtlPQ6AsWN0gVcYBooZ3CyF6qtFgkqBICKBA6u56VPUIP5Tk9d0AbfFI 2n6Doz/PmwkrRl0jWol3TmbaS9MesqrZvbkjeXTB63A3KaRHK46Ogr5N3iAfLiflZAH6wz jXWrqkIg7rCuGsRcZNn4J981t92VOnA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-Wm4mvU0YOvGQD5z0kAsJUQ-1; Thu, 05 Nov 2020 10:39:21 -0500 X-MC-Unique: Wm4mvU0YOvGQD5z0kAsJUQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1D62101962C; Thu, 5 Nov 2020 15:39:19 +0000 (UTC) Received: from [10.3.114.103] (ovpn-114-103.phx2.redhat.com [10.3.114.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E24D860C17; Thu, 5 Nov 2020 15:39:18 +0000 (UTC) Subject: Re: [PATCH] block: Fix integer promotion error in bdrv_getlength() To: Max Reitz , Tuguoyi , Kevin Wolf , "qemu-block@nongnu.org" References: <703e17a1-544f-4e5e-a431-6e20d4a04974@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <92c8524f-a43e-0f48-3bfc-6433968e18b1@redhat.com> Date: Thu, 5 Nov 2020 09:39:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 01:14:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chengchiwen , "qemu-devel@nongnu.org" , Wangyong Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/5/20 7:26 AM, Max Reitz wrote: >> I actually preferred the v1 solution, rather than this v2, as it avoided >> a cast. > > I don’t, because it doesn’t make the ?: go away, so I prefer the less > invasive version. > > If you want to send your suggested version (that drops both ?:), I’m > happy to take that instead. Will do. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org