From: Richard Henderson <richard.henderson@linaro.org>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/3] accel/tcg: Add debuginfo support
Date: Wed, 11 Jan 2023 10:14:37 -1000 [thread overview]
Message-ID: <92d0b7a8-1f67-96e7-8252-c37bb2e139e5@linaro.org> (raw)
In-Reply-To: <20230111014705.2275040-3-iii@linux.ibm.com>
On 1/10/23 17:47, Ilya Leoshkevich wrote:
> ginfo.h
> @@ -0,0 +1,77 @@
> +/*
> + * Debug information support.
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#ifndef ACCEL_TCG_DEBUGINFO_H
> +#define ACCEL_TCG_DEBUGINFO_H
> +
> +/*
> + * Debuginfo describing a certain address.
> + */
> +struct debuginfo_query {
> + unsigned long long address; /* Input: address. */
> + int flags; /* Input: debuginfo subset. */
> + const char *symbol; /* Symbol that the address is part of. */
> + unsigned long long offset; /* Offset from the symbol. */
> + const char *file; /* Source file associated with the address. */
> + int line; /* Line number in the source file. */
> +};
s/unsigned long long/uint64_t/g
Otherwise it looks reasonable.
r~
next prev parent reply other threads:[~2023-01-12 0:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 1:47 [PATCH v3 0/3] tcg: add perfmap and jitdump Ilya Leoshkevich
2023-01-11 1:47 ` [PATCH v3 1/3] linux-user: Clean up when exiting due to a signal Ilya Leoshkevich
2023-01-11 16:22 ` Alex Bennée
2023-01-11 20:07 ` Richard Henderson
2023-01-11 1:47 ` [PATCH v3 2/3] accel/tcg: Add debuginfo support Ilya Leoshkevich
2023-01-11 20:14 ` Richard Henderson [this message]
2023-01-11 1:47 ` [PATCH v3 3/3] tcg: add perfmap and jitdump Ilya Leoshkevich
2023-01-11 15:06 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92d0b7a8-1f67-96e7-8252-c37bb2e139e5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).