From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKnzD-0005Ax-Nv for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:39:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKnz8-0006nC-MP for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:39:34 -0400 References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-8-git-send-email-clord@redhat.com> From: Max Reitz Message-ID: <92e48bb9-f8b6-ffb0-66c1-4c4ae5e9ba8a@redhat.com> Date: Wed, 6 Jul 2016 16:39:20 +0200 MIME-Version: 1.0 In-Reply-To: <1467732272-23368-8-git-send-email-clord@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nI8iHxQJpr5nTVuWHvDc6dOmKmhRlw6KT" Subject: Re: [Qemu-devel] [PATCH v3 07/32] blockdev: Move dmg probe to its own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nI8iHxQJpr5nTVuWHvDc6dOmKmhRlw6KT From: Max Reitz To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Message-ID: <92e48bb9-f8b6-ffb0-66c1-4c4ae5e9ba8a@redhat.com> Subject: Re: [PATCH v3 07/32] blockdev: Move dmg probe to its own file References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-8-git-send-email-clord@redhat.com> In-Reply-To: <1467732272-23368-8-git-send-email-clord@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.07.2016 17:24, Colin Lord wrote: > Isolate dmg probe as part of the modularization process. >=20 > Signed-off-by: Colin Lord > --- > block/Makefile.objs | 2 +- > block/dmg.c | 16 +--------------- > block/probe/dmg.c | 17 +++++++++++++++++ > include/block/probe.h | 1 + > 4 files changed, 20 insertions(+), 16 deletions(-) > create mode 100644 block/probe/dmg.c Reviewed-by: Max Reitz [...] > diff --git a/block/probe/dmg.c b/block/probe/dmg.c > new file mode 100644 > index 0000000..a40281b > --- /dev/null > +++ b/block/probe/dmg.c > @@ -0,0 +1,17 @@ > +#include "qemu/osdep.h" > +#include "block/probe.h" > + > +int dmg_probe(const uint8_t *buf, int buf_size, const char *filename) > +{ > + int len; > + > + if (!filename) { > + return 0; > + } > + > + len =3D strlen(filename); > + if (len > 4 && !strcmp(filename + len - 4, ".dmg")) { Reading this probing code makes me feel all funny inside. :-) > + return 2; > + } > + return 0; > +} --nI8iHxQJpr5nTVuWHvDc6dOmKmhRlw6KT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXfRgYEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6Disrau1 B/9McugkS1rfm/vlhQ4+UzxVc0ErJLuUcEyHl8Jl/F4fY/J65s0QVTMX4XEh/vj1 CuBpLQVsJP7dgu0EwbK/x/ahoZdkw+5rc6h4H8Q0wmzQupPrNhtKLji3KqNGg26g 23viCCl9UDM8mbb8Fl55nCvVP/rHmQchlhQSk0rw7S0mDLqFetMexX75d9pd1KdY oeUuD1JXunQhvMW7eiGPq64fwb8zzs6OHoYmEnnrXf9XyXgjTKMuoxNDp0oWX4+9 +yOdVkPz/8hT72tXGydUTcDtTSoQQ1jj7RAvRNtd8JDYv5JQ26kNLhYDBvuW8u4O dV3xTfa5Ani1FMfmMBA/YUwT =Kafc -----END PGP SIGNATURE----- --nI8iHxQJpr5nTVuWHvDc6dOmKmhRlw6KT--