Re: [Qemu-devel] [PATCH v2 2/3] xen-platform: add support for unplugging NVMe disks...

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Stefano Stabellini [mailto:sstabellini@kernel.org]
> Sent: 24 January 2017 23:49
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano
> Stabellini <sstabellini@kernel.org>; Anthony Perard
> <anthony.perard@citrix.com>; Michael S. Tsirkin <mst@redhat.com>; Paolo
> Bonzini <pbonzini@redhat.com>; Richard Henderson <rth@twiddle.net>;
> Eduardo Habkost <ehabkost@redhat.com>; olaf@aepfle.de
> Subject: Re: [PATCH v2 2/3] xen-platform: add support for unplugging NVMe
> disks...
> 
> On Tue, 24 Jan 2017, Paul Durrant wrote:
> > ...not just IDE and SCSI.
> >
> > This patch allows the Xen tool-stack to fully support of NVMe as an
> > emulated disk type.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> 
> Please update docs/misc/hvm-emulated-unplug.markdown in the Xen
> repository first. It might be also worth clarifying that `1` actually
> means all disks, not just IDE disks. Then, please add a reference to
> that commit in the description of this patch.
>

Patch posted to remove 'IDE' from the documentation for value '1'. Awaiting ack.

  Paul 
 
> 
> > ---
> > Cc: Stefano Stabellini <sstabellini@kernel.org>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Richard Henderson <rth@twiddle.net>
> > Cc: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  hw/i386/xen/xen_platform.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
> > index f50915f..7d41ebb 100644
> > --- a/hw/i386/xen/xen_platform.c
> > +++ b/hw/i386/xen/xen_platform.c
> > @@ -120,6 +120,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d,
> void *o)
> >          break;
> >
> >      case PCI_CLASS_STORAGE_SCSI:
> > +    case PCI_CLASS_STORAGE_EXPRESS:
> >          object_unparent(OBJECT(d));
> >          break;
> >
> > --
> > 2.1.4
> >