Re: [PATCH 3/6] tests/functional: Fix problems in linuxkerenl.py reported by pylint

[Thomas Huth <thuth@redhat.com>]

On 22/10/2025 21.14, Philippe Mathieu-Daudé wrote:
> Typo "linuxkernel" in subject.
> 
> On 15/10/25 11:54, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> Use proper indentation and lazy logging here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   tests/functional/qemu_test/linuxkernel.py | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
>> @@ -48,5 +48,5 @@ def check_http_download(self, filename, hashsum, 
>> guestport=8080,
>>                   hl.update(chunk)
>>           digest = hl.hexdigest()
>> -        self.log.info(f'sha256sum of download is {digest}.')
>> +        self.log.info('sha256sum of download is %s.', digest)
>>           self.assertEqual(digest, hashsum)
> 
> TBH I don't understand why 'lazy logging' is better than f-strings.

If I got this right, it's about a small performance improvement: If the 
logging function decides that the log output could be dropped since the 
logging level does not match, there is no need to format the string in that 
case.

But thinking about this, I guess that's not a valuable argument for the 
tests, since we're not calling these functions again and again, so the 
performance impact is negligible here. So fine for me if we ignore this 
warning from pylint. ... i.e. we might want to introduce a pylintrc file 
now, similar to what we have in scripts/qapi/pylintrc or 
tests/qemu-iotests/pylintrc already ?

  Thomas