From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] docs: stop documenting the e1000 NIC model as the default
Date: Thu, 9 Jan 2020 13:48:52 +0100 [thread overview]
Message-ID: <933b100a-1ead-2f10-6540-8ba773fc81e7@redhat.com> (raw)
In-Reply-To: <20200109122913.3413914-1-berrange@redhat.com>
On 09/01/2020 13.29, Daniel P. Berrangé wrote:
> The default NIC model for QEMU varies per machine type, and is liable to
> change across machine type versions. Documenting e1000 NIC as the
> default for PC/i386 is thus misleading to users at best. In particular
> the PC q35 machine type switched to use e1000e, but only in machine
> type versions after 2.11.
>
> Rather than try to explain which NIC model is used for each machine
> type version, remove mention of e1000 as the default, and steer users
> towards always specifying their desired model.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> qemu-options.hx | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2020-01-09 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 12:29 [PATCH] docs: stop documenting the e1000 NIC model as the default Daniel P. Berrangé
2020-01-09 12:44 ` Aleksandar Markovic
2020-01-09 12:48 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=933b100a-1ead-2f10-6540-8ba773fc81e7@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).