From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grE2A-0002qG-4Z for qemu-devel@nongnu.org; Tue, 05 Feb 2019 22:37:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grE28-0003EW-Hv for qemu-devel@nongnu.org; Tue, 05 Feb 2019 22:37:58 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grE28-0003Dq-8F for qemu-devel@nongnu.org; Tue, 05 Feb 2019 22:37:56 -0500 Received: by mail-wr1-x444.google.com with SMTP id z3so5981760wrv.3 for ; Tue, 05 Feb 2019 19:37:55 -0800 (PST) References: <20190104223116.14037-1-richard.henderson@linaro.org> <362de5ba-a678-aeed-6a5d-3a02844c2560@linaro.org> <6314c25b-a8c9-a8e2-2e1d-a8eeb3b88f2c@ilande.co.uk> From: Richard Henderson Message-ID: <935af9ba-3fd8-ebd8-4f70-5050351d89d5@linaro.org> Date: Wed, 6 Feb 2019 03:37:50 +0000 MIME-Version: 1.0 In-Reply-To: <6314c25b-a8c9-a8e2-2e1d-a8eeb3b88f2c@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org Cc: Howard Spoelstra On 2/5/19 9:29 PM, Mark Cave-Ayland wrote: > The only minor question I had with the patchset in its current form is whether to use > the new VsrD() macro for vscr_sat, or whether we don't really care enough? Given the comment /* Which bit we set is completely arbitrary, but clear the rest. */ I don't think VsrD is helpful. In "target/ppc: Split out VSCR_SAT to a vector field": ppc_vsr_t vsr[64] QEMU_ALIGNED(16); + /* Non-zero if and only if VSCR_SAT should be set. */ + ppc_vsr_t vscr_sat; Better to add the QEMU_ALIGNED(16) to vscr_sat as well. Yes, it will already happen to be aligned by placement, but this is also a bit documentation. In "target/ppc: convert vadd*s and vsub*s to vector operations": if (sat) { \ - set_vscr_sat(env); \ + vscr_sat->u32[0] = 1; \ } \ Changed in error? r~