Re: [Qemu-devel] [PATCH] gitignore: Ignore vim per-project config and clang complete

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

On 06/01/2017 11:08 PM, Qu Wenruo wrote:
> Since we have already ignored ctags, ignoring .clangcomplete for
> vim-clang_completion is quite reasonable for me.
> (Not to mention vim-clang_completion provides better and more accurate
> completion and definition search)
> 
> Also, qemu coding style is using 4 space as indent other than 8-space
> tab, it also makes sense to ignore per-project vim config file.

We already have a per-project emacs config file (.dir-locals.el); I
think it would be a better idea if you were to propose adding an
appropriate .vim* file for inclusion in the project that makes vim work
out-of-the-box with correct settings, rather than masking the file as
unaddable and requiring all vim-using contributors to recreate the same
settings.  (But as I am not personally a vim user, I can neither provide
such a sample file myself, nor review one if you post it).

> 
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
> ---
>  .gitignore | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 55a001e3b8..c7c6eec0b6 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -113,6 +113,8 @@
>  cscope.*
>  tags
>  TAGS
> +.vim*
> +.clang_complete

The idea of adding .clang_complete to the exclusions makes sense to me.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]