From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zjojc-0007aW-Nx for qemu-devel@nongnu.org; Wed, 07 Oct 2015 09:26:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjojZ-00081R-IT for qemu-devel@nongnu.org; Wed, 07 Oct 2015 09:26:20 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:58084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjojZ-000813-BL for qemu-devel@nongnu.org; Wed, 07 Oct 2015 09:26:17 -0400 Date: Wed, 7 Oct 2015 09:26:15 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <937806384.26178243.1444224375430.JavaMail.zimbra@redhat.com> In-Reply-To: <5615188E.7080803@suse.de> References: <1444159184-18153-1-git-send-email-marcandre.lureau@redhat.com> <56150BE8.8020405@suse.de> <2075219250.26126659.1444220200013.JavaMail.zimbra@redhat.com> <20151007124247.GD3707@hawk.localdomain> <5615188E.7080803@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/48] ivshmem series List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: marcandre lureau , Andrew Jones , qemu-devel@nongnu.org, peter maydell Hi ----- Original Message ----- > Drew, >=20 > Am 07.10.2015 um 14:42 schrieb Andrew Jones: > > On Wed, Oct 07, 2015 at 08:16:40AM -0400, Marc-Andr=C3=A9 Lureau wrote: > >> ----- Original Message ----- > >>> Am 06.10.2015 um 21:18 schrieb marcandre.lureau@redhat.com: > >>>> Marc-Andr=C3=A9 Lureau (45): > >>> [...] > >>>> tests: add ivshmem qtest > >>> > >>> I had NAK'ed this patch in v1 and it has not been fixed. If this pull > >>> gets merged I will immediately revert it. Not funny. > >>> > >> > >> > >> Could stick to technical review, please. The test runs fine without kv= m. > >> Regarding your copyright claim, I already explain that your older vers= ion > >> of boilerplate test is really nothing compare to this one. But if you > >> feel so strongly about it, I don't care you add a copyright line. > >> > >=20 > > I would care if we added it. If contributors are getting bullied into > > outrageous demands, then there's something wrong. Something wrong is > > something we should try to fix, not just shrug off. And, in this case, > > Andreas' claim is quite outrageous. The patch[*] in question provided > > absolutely nothing that couldn't have been copy+pasted from any other > > qtest. >=20 > If something is outrageous, then the way Marc-Andr=C3=A9 is bullying *me*= by > 1) spinning his own version of my tests/ivshmem-test.c (not just copying It doesn't share anything but boilerplate qtest code. Btw, do you have a no= n-RFC version of this patch? > boilerplate from somewhere else), 2) spinning his own version of my > "make test" patch (which Peter keeps refusing to apply for two releases which patch are you talking about precisely here? > now) and 3) trying to sneak QOM changes in via trivial without CC'ing > me. Who knows what else I've missed. It's a recurring pattern. That's a mistake from me for removing a comment that I thought was trivial,= and forgot to CC the maintainer of the file too. Let's not mix unrelated things here. > I don't currently have as much time for upstream QEMU as I'd like, so > other people either ignoring the work that I did do or taking my work > and pretending that it is their own is truely offending to me. It was an > easy-to-address review comment that hardly qualifies as bullying - after > all he is also taking patches from 6wind.com properly. I don't think anyone is trying to offend you. However, since I am quite new= to the qemu project, it's understandable I make mistakes. Please try to be= a bit more friendly with newcomers. > I note that you are redhat.com, too. :) cheers