From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzRAA-0001gx-I5 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:58:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzRA5-0001dt-J4 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:58:02 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:43140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzRA5-0001dj-AJ for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:57:57 -0400 Date: Mon, 1 Jun 2015 10:57:55 -0400 (EDT) From: Paolo Bonzini Message-ID: <938219099.12500567.1433170675854.JavaMail.zimbra@redhat.com> In-Reply-To: <556C7234.6090300@redhat.com> References: <1433167752-5311-1-git-send-email-marcel@redhat.com> <556C686C.3090407@redhat.com> <556C6FFE.6000803@redhat.com> <556C7234.6090300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/q35: fix floppy controller definition in ich9 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: mst@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com > On 06/01/2015 05:45 PM, Paolo Bonzini wrote: > > The patch is okay, but the correct definition of the area is from 0x3F1 > > to 0x3F7. > Can we do other fixes on top of this? This patch solves the actual Windows > problem and now we can use floppies for Q35. Well, IANAM. :) > Can I take this okay as a "Reviewed-by"? ) Sure. Paolo