From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXsxa-0006lW-ML for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:35:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXsxT-0007Y7-J0 for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:35:57 -0400 Date: Thu, 11 Aug 2016 12:35:50 -0400 (EDT) From: Paolo Bonzini Message-ID: <938249601.1235079.1470933350319.JavaMail.zimbra@redhat.com> In-Reply-To: <1470932542-12311-1-git-send-email-kwolf@redhat.com> References: <1470932542-12311-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] coroutine: Assertions and debugging aids List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, stefanha@redhat.com, qemu-devel@nongnu.org > A while ago we were debugging a hang where coroutines were waiting for a > mutex > to be unlocked, but we couldn't find out who held the lock. This series adds > some information to Coroutine and CoMutex that both allows to add a few > assertions to check locking behaviour and can be used to find the culprit > when analysing a core dump. > > Kevin Wolf (2): > coroutine: Let CoMutex remember who holds it > coroutine: Assert that no locks are held on termination > > include/qemu/coroutine.h | 1 + > include/qemu/coroutine_int.h | 1 + > util/qemu-coroutine-lock.c | 14 ++++++++++++++ > util/qemu-coroutine.c | 1 + > 4 files changed, 17 insertions(+) Thanks for finally getting round to this. Reviewed-by: Paolo Bonzini