From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 699A0C25B75 for ; Mon, 13 May 2024 11:27:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6Tpg-0000Tr-Bd; Mon, 13 May 2024 07:27:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Tpd-0000TO-3h for qemu-devel@nongnu.org; Mon, 13 May 2024 07:27:01 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6Tpa-00008x-Vz for qemu-devel@nongnu.org; Mon, 13 May 2024 07:27:00 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-34e667905d2so2859679f8f.1 for ; Mon, 13 May 2024 04:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715599617; x=1716204417; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/G7MfgzCcN0jtEglp0t6kBbppY8sZFYe8E6d/jwHYcg=; b=DfDgY65CkKaOX+Cpy8Eikx6rhzf/S9sY1ZJY9EuB+hmYAfGFX0wLckwm6y/aR6y6PW 9O0sAZUfVyJkrYKrj7CDArEaBOT4UN9tik5wWS/3LLCpAEb+wJN2ucNIFQXrH9AaBUm+ HakPhTMvv3RX2qVB+RCSFVbt5qlQUqWXLZ/EfV9hUjyBgAowH5P11hZ70N8XnFB/RPEC 5/L34AZ5N+Knl3OC7vSTbz+4QUfyOhVP/zBAm2lFUjFXwlwZVtQu6UzHl92ULiHGhCUX eqU2PNe85tOusHPRTKq+8tnzLoTfuAEwhi+2aXLc6V6Y3BQbluO1cN5md/0jPJAD816w /Tuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715599617; x=1716204417; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/G7MfgzCcN0jtEglp0t6kBbppY8sZFYe8E6d/jwHYcg=; b=SeF7uyNX+8BSrHwA7zeMPoqPCaZDq36H3UME3XBa7V+Yb4InknuUXGq8Q1VioiXYy7 NfDtsKeCPmBis6Cr2JGwpQ8Lmv+I2rb/tGEot5iNYUVFDZjoOB9aR/VKgkT/Eg3Lm8PT F29REwDqv0S30mjvUcQaQdJ9hsGHgM2aOc5iJmYhqhInPF09adXlpM3JtNkGCC6RATId ZZlVF4oL0c9S5h7JoOqnJuL32HllPtxaqRvhbA0vP7CYZM/tpgHsVWFSQ7JIMQxQ/ZPW Pbd8quexpPtHTVrCd8wcTMjZkh8JLrVumDTKKRWG1crqOEcmoLhocpAd5gtDD9Uz/YuO cYzg== X-Forwarded-Encrypted: i=1; AJvYcCXeE5zWUrGDDRf6FKAQzpyN5c+YTFahPPgQT7WFqFuEmXy8WjbOO8DEiL0G5AD6AXYuSLhHn5osqLRhVcwmovMi/oNNGYY= X-Gm-Message-State: AOJu0YzA/7AlDFk+QFTNXKibjyVvzC6MVqvXS6S1dW3riL27hgAvYUdu Czr5WbpT/J6mRr41LN72VOibqo+FGNaHAr++x/1H1jiog1GkynjwsYyBxUsqqMk= X-Google-Smtp-Source: AGHT+IHHKRugbe7S2sosZWTGK6SMaDiKH339rK6MCwqegI28M3lHkG/hP7jmXPxx25wWZ8lnz7TgUw== X-Received: by 2002:adf:fa4d:0:b0:34f:fd71:9af with SMTP id ffacd0b85a97d-3504a73edbfmr6780716f8f.39.1715599617085; Mon, 13 May 2024 04:26:57 -0700 (PDT) Received: from [10.1.2.72] ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-351b79e8e6bsm3274119f8f.65.2024.05.13.04.26.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 04:26:56 -0700 (PDT) Message-ID: <93836d9f-56b7-464e-84a2-a101ca78e360@linaro.org> Date: Mon, 13 May 2024 13:26:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] hw/rtc/ds1338: Trace send and receive operations To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Peter Maydell , Michael Tokarev , Laurent Vivier , Jean-Christophe Dubois , qemu-trivial@nongnu.org, qemu-arm@nongnu.org References: <20240513101108.5237-1-shentey@gmail.com> <20240513101108.5237-2-shentey@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240513101108.5237-2-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 13/5/24 12:11, Bernhard Beschow wrote: > Signed-off-by: Bernhard Beschow > --- > hw/rtc/ds1338.c | 6 ++++++ > hw/rtc/trace-events | 4 ++++ > 2 files changed, 10 insertions(+) > @@ -134,6 +138,8 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data) > { > DS1338State *s = DS1338(i2c); > > + trace_ds1338_send(s->ptr, data); > --- a/hw/rtc/trace-events > +++ b/hw/rtc/trace-events > @@ -22,6 +22,10 @@ pl031_set_alarm(uint32_t ticks) "alarm set for %u ticks" > aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > > +# ds1338.c > +ds1338_recv(uint32_t addr, uint8_t value) "[0x%" PRIx32 "] -> 0x%02" PRIx8 > +ds1338_send(uint32_t addr, uint8_t value) "[0x%" PRIx32 "] <- 0x%02" PRIx8 DS1338State::ptr is signed, although being an offset, odd. Using unsigned in traces seems better anyway, Reviewed-by: Philippe Mathieu-Daudé