From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBBAC3A5A9 for ; Mon, 4 May 2020 09:42:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A7D7206D9 for ; Mon, 4 May 2020 09:42:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GdHLGty6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7D7206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVXcZ-0007oz-Bq for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 05:42:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVXbt-0007F5-7j for qemu-devel@nongnu.org; Mon, 04 May 2020 05:42:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:40233 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVXbr-0007SH-T9 for qemu-devel@nongnu.org; Mon, 04 May 2020 05:42:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588585316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JmNPkLtQYBvUd9wAytiAkkJxJzKin3wRn9aZ22wRXLo=; b=GdHLGty6uwECQFOQpIwi75BOibNJpD64lMlCVNXjkMeYM+ZTMp9neeDuU6Z6wBdMX39yDI GtuUDO8P0lHmcFJKp5YoGnJ81uASaU3lt6Rw279ETlYVvnF3Z0Xg6o/CAd1CgSGEkxIr3z wngjjZCytjy/prYqVohDY9Ttsn2sVII= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-i-OPPhpVN2iDc2pRNymPrg-1; Mon, 04 May 2020 05:41:55 -0400 X-MC-Unique: i-OPPhpVN2iDc2pRNymPrg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 475F91030981; Mon, 4 May 2020 09:41:54 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id BAF265C1B2; Mon, 4 May 2020 09:41:52 +0000 (UTC) Message-ID: <93921c24cdb5f70b3d836500bf0d3836c8a9fbb1.camel@redhat.com> Subject: Re: [PATCH] Fix iotest 153 From: Maxim Levitsky To: Max Reitz , qemu-devel@nongnu.org Date: Mon, 04 May 2020 12:41:51 +0300 In-Reply-To: References: <20200503164943.27215-1-mlevitsk@redhat.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.61; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 01:21:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 2020-05-04 at 11:22 +0200, Max Reitz wrote: > On 03.05.20 18:49, Maxim Levitsky wrote: > > Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o= "" but this test uses it > >=20 > > Since this test only tries to do a dry-run run of qemu-img amend, repla= ce the -o "" with > > dummy -o "size=3D0" since due to the nature of the test, it is not goin= g > > to reach the actual amend operation anyway > >=20 > > Fixes: f62514b3def5fb2acbef64d0e053c0c31fa45aff > >=20 > > Signed-off-by: Maxim Levitsky > > --- > > tests/qemu-iotests/153 | 2 +- > > tests/qemu-iotests/153.out | 12 ++++++------ > > 2 files changed, 7 insertions(+), 7 deletions(-) > >=20 > > diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 > > index 2b13111768..3f5029dd8f 100755 > > --- a/tests/qemu-iotests/153 > > +++ b/tests/qemu-iotests/153 > > @@ -122,7 +122,7 @@ for opts1 in "" "read-only=3Don" "read-only=3Don,fo= rce-share=3Don"; do > > _run_cmd $QEMU_IMG check $L "${TEST_IMG}" > > _run_cmd $QEMU_IMG compare $L "${TEST_IMG}" "${TEST_IMG}" > > _run_cmd $QEMU_IMG map $L "${TEST_IMG}" > > - _run_cmd $QEMU_IMG amend -o "" $L "${TEST_IMG}" > > + _run_cmd $QEMU_IMG amend -o "size=3D0" $L "${TEST_IMG}" >=20 > AFAIU we don=E2=80=99t want this command to actually change the image (he= nce the > empty options list, which would result in nothing being changed), so > maybe "size=3D$size" would be more in the spirit of the test? This is a good idea! Should I resend the patch or you can add this change l= ocally? Best regards, =09Maxim Levitsky >=20 > Max >=20