From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Beata Michalska <beata.michalska@linaro.org>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-arm@nongnu.org, Keith Busch <kbusch@kernel.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic
Date: Fri, 8 May 2020 08:33:27 +0200 [thread overview]
Message-ID: <9396e0cb-388a-e08e-c066-82a60708ecdc@redhat.com> (raw)
In-Reply-To: <20200508062456.23344-1-philmd@redhat.com>
On 08/05/20 08:24, Philippe Mathieu-Daudé wrote:
> It is not clear if dccvap_writefn() really needs
> memory_region_writeback() or could use memory_region_msync().
Indeed, I don't understand the code and why it matters that
mr->dirty_log_mask is nonzero.
mr->dirty_log_mask tells if dirty tracking has been enabled, not if the
page is dirty. It would always be true during live migration and when
running on TCG, but otherwise it would always be false.
Beata, can you explain what you had in mind? :)
Paolo
next prev parent reply other threads:[~2020-05-08 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:24 [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic Philippe Mathieu-Daudé
2020-05-08 6:24 ` [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback Philippe Mathieu-Daudé
2020-05-08 20:16 ` Richard Henderson
2020-05-08 6:24 ` [PATCH 2/4] memory: Extract memory_region_msync() from memory_region_writeback() Philippe Mathieu-Daudé
2020-05-08 6:24 ` [PATCH 3/4] hw/block: Let the NVMe emulated device be target-agnostic Philippe Mathieu-Daudé
2020-05-08 20:25 ` Richard Henderson
2020-05-08 6:24 ` [PATCH 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync() Philippe Mathieu-Daudé
2020-05-08 20:25 ` Richard Henderson
2020-05-08 6:33 ` Paolo Bonzini [this message]
2020-05-08 15:20 ` [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic Beata Michalska
2020-05-08 15:33 ` Paolo Bonzini
2020-05-08 15:34 ` Philippe Mathieu-Daudé
2020-05-08 15:35 ` Philippe Mathieu-Daudé
2020-05-08 15:58 ` Paolo Bonzini
2020-05-21 12:32 ` Stefan Hajnoczi
2020-05-21 12:46 ` Paolo Bonzini
2020-05-21 14:21 ` Philippe Mathieu-Daudé
2020-05-27 12:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9396e0cb-388a-e08e-c066-82a60708ecdc@redhat.com \
--to=pbonzini@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).