From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"John Snow" <jsnow@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: proposal: deprecate -readconfig/-writeconfig
Date: Thu, 14 May 2020 17:51:02 +0200 [thread overview]
Message-ID: <93bda646-6f5f-69b6-57ec-36ec9485e84c@redhat.com> (raw)
In-Reply-To: <20200514153456.GL1280939@redhat.com>
On 14/05/20 17:34, Daniel P. Berrangé wrote:
> Yeah, the key thing is that you really want to be able to provide the
> whole initial config in one go as an atomic action. I don't want to
> issue 100 individual QMP commands to load each initial device.
Why? I think if we do something like the qemu-vm-$TARGET that you
propose below, there's absolutely no difference between the two.
Then you'd have a
qemu-run /some/file.yaml
(notice the lack of $TARGET) that takes care of starting the VM.
> I tend to think we'd be better served by focusing on introducing a new set
> of binaries, qemu-vm-$TARGET, which exclusively use a new config syntax,
> free of any legacy baggage present in qemu-system-$TARGET.
>
> Work on qemu-vm-$TARGET will involve refactoring, and that will certainly
> risk causing bugs in qemu-system-$TARGET. The premise though is that this
> risk is lower, than if we tried to retrofit a new config syuntax directly
> into qemu-system-$TARGET.
>
> In particular I think it is basically impossible to do any meaningful
> changes in the main() method of softmmu/vl.c, due to the fragile ordering
> for creation of various different devices/backends, and its interaction
> with the argv parsing. By using a new qemu-vm-$TARGET we can have a new
> softmmu/vm.c, instead of vl.c. We'll still likely need to modify parts of
> vl.c to use new/changed API calls, but that's less distruptive, as we
> can leave the crazy logic for ordering of device creation untouched.
Agreed.
Paolo
next prev parent reply other threads:[~2020-05-14 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 8:09 proposal: deprecate -readconfig/-writeconfig Paolo Bonzini
2020-05-14 8:54 ` Gerd Hoffmann
2020-05-15 5:31 ` Markus Armbruster
2020-05-14 8:56 ` Daniel P. Berrangé
2020-05-14 12:37 ` Paolo Bonzini
2020-05-15 5:54 ` Markus Armbruster
2020-05-15 10:19 ` Paolo Bonzini
2020-05-14 14:40 ` John Snow
2020-05-14 15:34 ` Daniel P. Berrangé
2020-05-14 15:51 ` Paolo Bonzini [this message]
2020-05-14 15:55 ` Daniel P. Berrangé
2020-05-15 5:44 ` Markus Armbruster
2020-05-15 5:51 ` Markus Armbruster
2020-05-15 9:06 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93bda646-6f5f-69b6-57ec-36ec9485e84c@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).