From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45881)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1eu0AQ-0001KY-Kh
	for qemu-devel@nongnu.org; Thu, 08 Mar 2018 13:21:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1eu0AN-0000d1-FI
	for qemu-devel@nongnu.org; Thu, 08 Mar 2018 13:21:26 -0500
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38866 helo=mx1.redhat.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1eu0AN-0000cf-AN
	for qemu-devel@nongnu.org; Thu, 08 Mar 2018 13:21:23 -0500
References: <1518692807-25859-1-git-send-email-thuth@redhat.com>
	<8ccf0ec6-4eb4-7039-ca51-1fbcd192fa2a@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <93bf7fb0-2bd0-0c23-1a3a-b73f31ff313b@redhat.com>
Date: Thu, 8 Mar 2018 19:21:20 +0100
MIME-Version: 1.0
In-Reply-To: <8ccf0ec6-4eb4-7039-ca51-1fbcd192fa2a@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Polish the version strings containing the
 package version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

On 15.02.2018 15:38, Eric Blake wrote:
> On 02/15/2018 05:06 AM, Thomas Huth wrote:
>> Since commit 67a1de0d195a there is no space anymore between the
>> version number and the parentheses when running configure with
>> --with-pkgversion=3Dfoo :
>>
>> =C2=A0 $ qemu-system-s390x --version
>> =C2=A0 QEMU emulator version 2.11.50(foo)
>>
>> But the space is included when building without that option
>> when building from a git checkout:
>>
>> =C2=A0 $ qemu-system-s390x --version
>> =C2=A0 QEMU emulator version 2.11.50 (v2.11.0-1494-gbec9c64-dirty)
>>
>> The same confusion exists with the "query-version" QMP command.
>> Let's fix this by introducing a proper QEMU_FULL_VERSION definition
>> that includes the space and parentheses, while the QEMU_PKGVERSION
>> should just cleanly contain the package version string itself.
>> Note that this also changes the behavior of the "query-version" QMP
>> command (the space and parentheses are not included there anymore),
>> but that's supposed to be OK since the strings there are not meant
>> to be parsed by other tools.
>>
>> Fixes: 67a1de0d195a6185c39b436159c9ffc7720bf979
>> Buglink: https://bugs.launchpad.net/qemu/+bug/1673373
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>=20
> I like it!
>=20
> Reviewed-by: Eric Blake <eblake@redhat.com>

Ping!

Paolo, could you maybe take this through your misc tree?

 Thomas