From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org
Subject: Re: [PATCH] chardev: clean up chardev-parallel.c
Date: Thu, 22 Dec 2022 09:04:00 +0100 [thread overview]
Message-ID: <93c3e291-7a0b-c9b9-c1ae-479c05ffbfce@linaro.org> (raw)
In-Reply-To: <20221222073800.856970-1-pbonzini@redhat.com>
On 22/12/22 08:38, Paolo Bonzini wrote:
> Replace HAVE_CHARDEV_PARPORT with a Meson conditional, remove unnecessary
> defines, and close the file descriptor on FreeBSD/DragonFly.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> chardev/char-parallel.c | 15 ++-------------
> chardev/meson.build | 5 ++++-
> include/qemu/osdep.h | 5 -----
> 3 files changed, 6 insertions(+), 19 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-12-22 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 7:38 [PATCH] chardev: clean up chardev-parallel.c Paolo Bonzini
2022-12-22 8:04 ` Philippe Mathieu-Daudé [this message]
2023-01-02 11:56 ` Marc-André Lureau
-- strict thread matches above, loose matches on Subject: below --
2022-12-19 9:17 Paolo Bonzini
2022-12-19 9:23 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c3e291-7a0b-c9b9-c1ae-479c05ffbfce@linaro.org \
--to=philmd@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).