From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Ewan Hai" <ewanhai-oc@zhaoxin.com>, "Tao Su" <tao1.su@intel.com>,
"Yi Lai" <yi1.lai@intel.com>, "Dapeng Mi" <dapeng1.mi@intel.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] i386/cpu: Mark ECX/EDX in CPUID 0x80000008 leaf as reserved for Intel
Date: Tue, 1 Jul 2025 09:00:23 +0800 [thread overview]
Message-ID: <93cac118-87d7-4742-99b5-057609108abb@intel.com> (raw)
In-Reply-To: <aGIeuV5QKTIbtkeu@intel.com>
On 6/30/2025 1:20 PM, Zhao Liu wrote:
>>> + if (cpu->vendor_cpuid_only_v2 && IS_INTEL_CPU(env)) {
>>> + *ecx = *edx = 0;
>>> + break;
>>> + }
>>
>> current code guarantees ecx and edx to be 0 for !IS_AMD_CPU(). I think the
>> patch is unnecessary.
>
> Hi, could you please tell me why?
Sorry that I was looking at the wrong branch, which has my previous
patch of
https://lore.kernel.org/qemu-devel/20240814075431.339209-7-xiaoyao.li@intel.com/
My patch isn't merged and you patch is not unnecessary.
Sorry again.
> Thanks,
> Zhao
>
>>> if (threads_per_pkg > 1) {
>>> /*
>>> * Bits 15:12 is "The number of bits in the initial
>>
next prev parent reply other threads:[~2025-07-01 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 3:51 [PATCH 0/4] i386/cpu: Clean Up Reserved CPUID Leaves for Intel Zhao Liu
2025-06-27 3:51 ` [PATCH 1/4] i386/cpu: Mark EBX/ECX/EDX in CPUID 0x80000000 leaf as reserved " Zhao Liu
2025-06-27 5:52 ` Ewan Hai
2025-06-27 8:20 ` Xiaoyao Li
2025-06-27 3:51 ` [PATCH 2/4] i386/cpu: Mark CPUID 0x80000007[EBX] " Zhao Liu
2025-06-27 5:52 ` Ewan Hai
2025-06-27 3:51 ` [PATCH 3/4] i386/cpu: Mark ECX/EDX in CPUID 0x80000008 leaf " Zhao Liu
2025-06-27 5:52 ` Ewan Hai
2025-06-27 8:24 ` Xiaoyao Li
2025-06-30 5:20 ` Zhao Liu
2025-07-01 1:00 ` Xiaoyao Li [this message]
2025-06-27 3:51 ` [PATCH 4/4] i386/cpu: Reorder CPUID leaves in cpu_x86_cpuid() Zhao Liu
2025-06-27 8:17 ` [PATCH 0/4] i386/cpu: Clean Up Reserved CPUID Leaves for Intel Xiaoyao Li
2025-07-07 0:55 ` Tao Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93cac118-87d7-4742-99b5-057609108abb@intel.com \
--to=xiaoyao.li@intel.com \
--cc=berrange@redhat.com \
--cc=dapeng1.mi@intel.com \
--cc=ewanhai-oc@zhaoxin.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tao1.su@intel.com \
--cc=yi1.lai@intel.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).