From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] tcg: Optimize inline dup_const for MO_64
Date: Tue, 19 Jan 2021 20:25:01 +0100 [thread overview]
Message-ID: <93d2fbc4-6fdb-6b42-5a0c-65110430b4bc@redhat.com> (raw)
In-Reply-To: <20210119185542.628456-3-richard.henderson@linaro.org>
On 19.01.21 19:55, Richard Henderson wrote:
> Avoid the out-of-line function call for immediate MO_64.
> In addition, diagnose all invalid constants at compile-time.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/tcg/tcg.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
> index 504c5e9bb0..c5a9d65d5f 100644
> --- a/include/tcg/tcg.h
> +++ b/include/tcg/tcg.h
> @@ -1325,7 +1325,8 @@ uint64_t dup_const(unsigned vece, uint64_t c);
> ? ( (VECE) == MO_8 ? 0x0101010101010101ull * (uint8_t)(C) \
> : (VECE) == MO_16 ? 0x0001000100010001ull * (uint16_t)(C) \
> : (VECE) == MO_32 ? 0x0000000100000001ull * (uint32_t)(C) \
> - : dup_const(VECE, C)) \
> + : (VECE) == MO_64 ? (uint64_t)(C) \
> + : (qemu_build_not_reached_always(), 0)) \
> : dup_const(VECE, C))
>
>
>
Looks good to me!
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-01-19 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 18:55 [PATCH 0/2] tcg: Optimize inline dup_const for MO_64 Richard Henderson
2021-01-19 18:55 ` [PATCH 1/2] qemu/compiler: Split out qemu_build_not_reached_always Richard Henderson
2021-01-19 22:13 ` Philippe Mathieu-Daudé
2021-01-19 18:55 ` [PATCH 2/2] tcg: Optimize inline dup_const for MO_64 Richard Henderson
2021-01-19 19:25 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93d2fbc4-6fdb-6b42-5a0c-65110430b4bc@redhat.com \
--to=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).