qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel'
Date: Tue, 2 May 2017 17:09:42 +0200	[thread overview]
Message-ID: <93de273c-9a3b-dcb8-dd6e-8b9b4fb09a65@redhat.com> (raw)
In-Reply-To: <87pofrfgl3.fsf@dusky.pond.sub.org>



On 02/05/2017 17:01, Markus Armbruster wrote:
>> But I really, really see no point in removing --enable-kvm.  It costs
>> perhaps 10 lines of code that has pretty much no ramifications elsewhere
>> in the code.  If anything I'd expect "-machine accel" to disappear
>> before, if ever (in favor of multiple "-accel" options, e.g. "-machine
>> accel=kvm:tcg" can become "-accel kvm -accel tcg".
> I basically agree, except I wouldn't say "no point", but "doesn't buy us
> enough to justify inconveniencing users".
> 
> What we've done before for options that have become unloved, but not
> harmful, is remove them just from documentation.  Grep qemu-options.hx
> for "HXCOMM Deprecated".  Let's do that for --enable-kvm and similarly
> weird sugared options.

Except that this provides no easily greppable way to find how to enable
KVM, as things stand.  So the first lesson should be "no deprecation
without documentation" (any reference to 18th century political slogans
is purely coincidential :)).

Paolo

  reply	other threads:[~2017-05-02 15:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 10:06 [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel' Thomas Huth
2017-05-02 10:21 ` Daniel P. Berrange
2017-05-02 10:29   ` Thomas Huth
2017-05-02 10:32 ` Christian Borntraeger
2017-05-02 10:37   ` Thomas Huth
2017-05-02 10:48     ` Christian Borntraeger
2017-05-02 11:26       ` Thomas Huth
2017-05-02 11:59         ` Daniel P. Berrange
2017-05-02 12:07           ` Thomas Huth
2017-05-02 12:14             ` Thomas Huth
2017-05-02 12:16             ` Daniel P. Berrange
2017-05-02 12:38               ` Daniel P. Berrange
2017-05-02 12:46                 ` Thomas Huth
2017-05-02 13:22       ` Paolo Bonzini
2017-05-02 15:01         ` Markus Armbruster
2017-05-02 15:09           ` Paolo Bonzini [this message]
2017-05-02 15:53             ` Thomas Huth
2017-05-02 16:08               ` Paolo Bonzini
2017-05-02 16:19                 ` Thomas Huth
2017-05-02 16:22                   ` Paolo Bonzini
2017-05-03  8:07                     ` Markus Armbruster
2017-05-02 12:21     ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93de273c-9a3b-dcb8-dd6e-8b9b4fb09a65@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).