From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B7E2C282DE for ; Mon, 10 Mar 2025 15:47:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trfKr-0007i7-Nf; Mon, 10 Mar 2025 11:46:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trfKS-0007ci-HG; Mon, 10 Mar 2025 11:46:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trfKL-0004TH-6U; Mon, 10 Mar 2025 11:46:07 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52ACVFQI007762; Mon, 10 Mar 2025 15:45:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=Fso/ga 1MNe7B6Uw8bOZ4AKLWWGvRUM7FY+U1XaVsH5Q=; b=OaAjjnJlHMiW4JYU7sHGZ8 K1jJo5gATRMRPPxcY6WUzY/NP+AclUMVZZSLB1OXZj3uYTZgyo4J0UYP4OeTlo05 VrbH5ab98johZolMk2RqvksT0cnQUzANGl0WgRYke6cPCeUrcwwHJKLOnrZu4KX2 PLRTEqy1uPXYW9H9ImVIYIvqGgjS9NPeilHXPXWB3zk1Oa01JeHIMTmsVj9CMQqD Uuja8Y2CXrq47KsH1ioAziqCF/gK315Y8QrBtw5XfJBF2ZuTxxs9S6wACOTIDoCq Xxw/GjlrG0Nab5loz96mV53GdSbqEqg06KMWLtGy2OcXIo2XU4iMWLZ2VHz+duNw == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 459j6ym7cb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Mar 2025 15:45:57 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52ADeJ8J023888; Mon, 10 Mar 2025 15:45:57 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4590kyqfs1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Mar 2025 15:45:57 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52AFjti625231896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Mar 2025 15:45:56 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB98E58057; Mon, 10 Mar 2025 15:45:55 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CBDB5805D; Mon, 10 Mar 2025 15:45:55 +0000 (GMT) Received: from [9.61.127.211] (unknown [9.61.127.211]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 10 Mar 2025 15:45:54 +0000 (GMT) Message-ID: <93e49bcb-e0e5-4966-bc8c-502b3fb02ac4@linux.ibm.com> Date: Mon, 10 Mar 2025 11:45:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 3/5] hw/vfio/ap: store object indicating AP config changed in a queue To: Rorie Reyes , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, clg@redhat.com, thuth@redhat.com References: <20250310153552.32987-1-rreyes@linux.ibm.com> <20250310153552.32987-4-rreyes@linux.ibm.com> Content-Language: en-US From: Anthony Krowiak In-Reply-To: <20250310153552.32987-4-rreyes@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: CPQRWIyWsN7V0N_1Foi4L14KMV8w6y2h X-Proofpoint-ORIG-GUID: CPQRWIyWsN7V0N_1Foi4L14KMV8w6y2h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-10_06,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503100121 Received-SPF: pass client-ip=148.163.158.5; envelope-from=akrowiak@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/10/25 11:35 AM, Rorie Reyes wrote: > Creates an object indicating that an AP configuration change event > has been received and stores it in a queue. These objects will later > be used to store event information for an AP configuration change > when the CHSC instruction is intercepted. > > Signed-off-by: Rorie Reyes > --- > hw/vfio/ap.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index 3614657218..ddab764ab4 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -41,6 +41,13 @@ struct VFIOAPDevice { > EventNotifier cfg_notifier; > }; > > +typedef struct APConfigChgEvent { > + QTAILQ_ENTRY(APConfigChgEvent) next; > +} APConfigChgEvent; > + > +QTAILQ_HEAD(, APConfigChgEvent) cfg_chg_events = > + QTAILQ_HEAD_INITIALIZER(cfg_chg_events); > + > OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE) > > static void vfio_ap_compute_needs_reset(VFIODevice *vdev) > @@ -75,11 +82,14 @@ static void vfio_ap_req_notifier_handler(void *opaque) > static void vfio_ap_cfg_chg_notifier_handler(void *opaque) > { > VFIOAPDevice *vapdev = opaque; > + APConfigChgEvent *cfg_chg_event = g_new0(APConfigChgEvent, 1); It doesn't make sense to allocate this before the check below. If the event_notifier_test_and_clear() fails, you'll have allocated this for no reason. Allocate cfg_cgh_event prior to inserting it into the queue below. > > if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) { > return; > } > > + QTAILQ_INSERT_TAIL(&cfg_chg_events, cfg_chg_event, next); > + > css_generate_css_crws(0); > > }