From: Richard Henderson <richard.henderson@linaro.org>
To: David Miller <dmiller423@gmail.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: thuth@redhat.com, david@redhat.com, cohuck@redhat.com,
farman@linux.ibm.com, pasic@linux.ibm.com,
borntraeger@linux.ibm.com
Subject: Re: [PATCH v6 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3
Date: Wed, 23 Feb 2022 09:45:22 -1000 [thread overview]
Message-ID: <93ff22ad-ca20-e009-d8eb-12ca0ba63668@linaro.org> (raw)
In-Reply-To: <20220217231728.13932-4-dmiller423@gmail.com>
On 2/17/22 13:17, David Miller wrote:
> +#define F_PRO asm ( \
> + "lg %%r2, %[a]\n" \
> + "lg %%r3, %[b]\n" \
> + "lg %%r0, %[c]\n" \
> + "ltgr %%r0, %%r0" \
> + : : [a] "m" (a), \
> + [b] "m" (b), \
> + [c] "m" (c) \
> + : "r0", "r2", "r3", "r4")
> +
> +
> +
> +#define Fi3(S, ASM) uint64_t S(uint64_t a, uint64_t b, uint64_t c) \
> +{ uint64_t res = 0; F_PRO ; ASM ; return res; }
> +
> +
> +Fi3 (_selre, asm("selre %%r0, %%r3, %%r2\n" F_EPI))
> +Fi3 (_selgrz, asm("selgrz %%r0, %%r3, %%r2\n" F_EPI))
> +Fi3 (_selfhrnz, asm("selfhrnz %%r0, %%r3, %%r2\n" F_EPI))
You can't split these two asm, lest the ltgr and sel not be adjacent, and the flags not
having the correct value when we arrive at the sel.
No test for popcnt, seeing as there's a bug in m3?
r~
next prev parent reply other threads:[~2022-02-23 19:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 23:17 [PATCH v6 0/4] s390x: Add partial z15 support and tests David Miller
2022-02-17 23:17 ` [PATCH v6 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x David Miller
2022-02-23 13:40 ` Christian Borntraeger
2022-02-23 22:29 ` David Miller
2022-02-24 7:04 ` Christian Borntraeger
2022-02-23 19:40 ` Richard Henderson
2022-02-23 21:11 ` David Miller
2022-02-17 23:17 ` [PATCH v6 2/4] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1 David Miller
2022-02-17 23:17 ` [PATCH v6 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3 David Miller
2022-02-23 19:45 ` Richard Henderson [this message]
2022-02-23 20:17 ` David Miller
2022-02-17 23:17 ` [PATCH v6 4/4] tests/tcg/s390x: changed to using .insn for tests requiring z15 David Miller
2022-02-23 10:44 ` Thomas Huth
2022-02-23 10:54 ` David Hildenbrand
2022-02-23 11:49 ` Thomas Huth
2022-02-23 11:51 ` David Hildenbrand
2022-02-23 11:52 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93ff22ad-ca20-e009-d8eb-12ca0ba63668@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmiller423@gmail.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).