From: Thomas Huth <thuth@redhat.com>
To: Yi Wang <wang.yi59@zte.com.cn>, qemu-devel@nongnu.org
Cc: wang.liang82@zte.com.cn, QEMU Trivial <qemu-trivial@nongnu.org>,
qemu-ppc@nongnu.org, xue.zhihong@zte.com.cn,
Liao Pingfang <liao.pingfang@zte.com.cn>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 02/12] target/ppc: Remove superfluous breaks
Date: Mon, 13 Jul 2020 11:30:58 +0200 [thread overview]
Message-ID: <9429f7c1-0bcf-5092-9f39-302f6b1cf598@redhat.com> (raw)
In-Reply-To: <1594631025-36219-1-git-send-email-wang.yi59@zte.com.cn>
On 13/07/2020 11.03, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/ppc/misc_helper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
> index 55b68d1..e43a3b4 100644
> --- a/target/ppc/misc_helper.c
> +++ b/target/ppc/misc_helper.c
> @@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
> case 0x0CUL:
> /* Instruction cache line size */
> return env->icache_line_size;
> - break;
> case 0x0DUL:
> /* Data cache line size */
> return env->dcache_line_size;
> - break;
> case 0x0EUL:
> /* Minimum cache line size */
> return (env->icache_line_size < env->dcache_line_size) ?
> env->icache_line_size : env->dcache_line_size;
> - break;
> case 0x0FUL:
> /* Maximum cache line size */
> return (env->icache_line_size > env->dcache_line_size) ?
> env->icache_line_size : env->dcache_line_size;
> - break;
> default:
> /* Undefined */
> return 0;
> - break;
> }
> }
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-07-13 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 9:03 [PATCH 02/12] target/ppc: Remove superfluous breaks Yi Wang
2020-07-13 9:30 ` Thomas Huth [this message]
2020-09-01 6:34 ` Laurent Vivier
2020-07-13 10:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9429f7c1-0bcf-5092-9f39-302f6b1cf598@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=liao.pingfang@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).