qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [RFC PATCH 0/4] hw/arm: Register target-specific QOM types at runtime
Date: Wed, 5 Mar 2025 08:53:30 -0800	[thread overview]
Message-ID: <942e2191-0952-4838-bbc5-913528d91f16@linaro.org> (raw)
In-Reply-To: <20250305161248.54901-1-philmd@linaro.org>

On 3/5/25 08:12, Philippe Mathieu-Daudé wrote:
> In preparation of having a single binary for both ARM and
> Aarch64 targets, unify raspi & aspeed by replacing the
> compile-time TARGET_AARCH64 check by a QOM runtime call
> on legacy_binary_is_64bit().
> 
> No behavior change with current binaries:
> 
>    $ ./qemu-system-arm -M help | fgrep raspi
>    raspi0               Raspberry Pi Zero (revision 1.2)
>    raspi1ap             Raspberry Pi A+ (revision 1.1)
>    raspi2b              Raspberry Pi 2B (revision 1.1)
> 
>    $ ./qemu-system-aarch64 -M help | fgrep raspi
>    raspi0               Raspberry Pi Zero (revision 1.2)
>    raspi1ap             Raspberry Pi A+ (revision 1.1)
>    raspi2b              Raspberry Pi 2B (revision 1.1)
>    raspi3ap             Raspberry Pi 3A+ (revision 1.0)
>    raspi3b              Raspberry Pi 3B (revision 1.2)
>    raspi4b              Raspberry Pi 4B (revision 1.5)
> 

To see an effect on those changes, we should ideally make sure those 
files can compile while being common (in meson.build system_ss), so we 
are sure they don't depend on target define anymore.

> Based-on: <20250305153929.43687-1-philmd@linaro.org>
> 
> Philippe Mathieu-Daudé (4):
>    qom: Introduce TypeInfo::registerable() callback
>    hw/arm/raspi: Replace TARGET_AARCH64 by legacy_binary_is_64bit()
>    hw/arm/aspeed: Replace TARGET_AARCH64 by legacy_binary_is_64bit()
>    hw/ppc: Remove TARGET_PPC64 use in ppc_create_page_sizes_prop()
> 
>   include/qom/object.h | 1 +
>   hw/arm/aspeed.c      | 8 ++------
>   hw/arm/bcm2836.c     | 6 ++----
>   hw/arm/raspi.c       | 7 +++----
>   hw/ppc/fdt.c         | 5 +++--
>   qom/object.c         | 4 ++++
>   qom/trace-events     | 1 +
>   7 files changed, 16 insertions(+), 16 deletions(-)
> 


      parent reply	other threads:[~2025-03-05 16:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 16:12 [RFC PATCH 0/4] hw/arm: Register target-specific QOM types at runtime Philippe Mathieu-Daudé
2025-03-05 16:12 ` [RFC PATCH 1/4] qom: Introduce TypeInfo::registerable() callback Philippe Mathieu-Daudé
2025-03-05 16:47   ` Pierrick Bouvier
2025-03-06  1:34   ` Richard Henderson
2025-03-05 16:12 ` [RFC PATCH 2/4] hw/arm/raspi: Replace TARGET_AARCH64 by legacy_binary_is_64bit() Philippe Mathieu-Daudé
2025-03-05 16:50   ` Pierrick Bouvier
2025-03-05 17:40   ` Thomas Huth
2025-03-05 18:12     ` Cédric Le Goater
2025-03-05 18:35       ` Thomas Huth
2025-03-05 19:07         ` Philippe Mathieu-Daudé
2025-03-05 20:41           ` BALATON Zoltan
2025-03-06  6:12           ` Thomas Huth
2025-03-06  9:21   ` Daniel P. Berrangé
2025-03-06 10:13     ` Peter Maydell
2025-03-05 16:12 ` [RFC PATCH 3/4] hw/arm/aspeed: " Philippe Mathieu-Daudé
2025-03-05 16:33   ` Cédric Le Goater
2025-03-05 17:07     ` Philippe Mathieu-Daudé
2025-03-05 17:43   ` Thomas Huth
2025-03-05 16:12 ` [RFC PATCH 4/4] hw/ppc: Remove TARGET_PPC64 use in ppc_create_page_sizes_prop() Philippe Mathieu-Daudé
2025-03-05 16:52   ` Pierrick Bouvier
2025-03-05 16:53 ` Pierrick Bouvier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=942e2191-0952-4838-bbc5-913528d91f16@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=clg@kaod.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).