From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kwolf@redhat.com, Jason Baron <jbaron@redhat.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances
Date: Sat, 15 Dec 2012 04:14:14 -0500 (EST) [thread overview]
Message-ID: <945049786.24997408.1355562854731.JavaMail.root@redhat.com> (raw)
In-Reply-To: <CAAu8pHuweRYQq=DdE+ZLODCdD1S-qS-jx_FyRZQYmDJqzeKBXg@mail.gmail.com>
> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock"
> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp"
> > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid"
>
> These filenames are too predictable from security point of view,
This need not be secure as long as the file is created with 0600
permissions. In fact, inspecting the pid file from the shell can
be useful.
However, using mkstemp() on a prefix that includes the parent pid
can indeed be the best of both worlds.
Paolo
next prev parent reply other threads:[~2012-12-15 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 22:02 [Qemu-devel] [PATCH 0/3] qtest: add migration testing Jason Baron
2012-12-13 22:02 ` [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances Jason Baron
2012-12-14 20:30 ` Blue Swirl
2012-12-15 9:14 ` Paolo Bonzini [this message]
2012-12-15 9:20 ` Blue Swirl
2012-12-17 17:13 ` Jason Baron
2012-12-19 19:42 ` Blue Swirl
2012-12-13 22:02 ` [Qemu-devel] [PATCH 2/3] qtest: extend qtest_qmp() to fill in the reply Jason Baron
2012-12-14 0:07 ` Andreas Färber
2012-12-14 16:10 ` Jason Baron
2012-12-13 22:02 ` [Qemu-devel] [PATCH 3/3] qtest: add migrate-test Jason Baron
2012-12-14 8:08 ` Paolo Bonzini
2012-12-14 16:14 ` Jason Baron
2012-12-14 17:25 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945049786.24997408.1355562854731.JavaMail.root@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=jbaron@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).