From: Paolo Bonzini <pbonzini@redhat.com>
To: Frederic Konrad <fred.konrad@greensocs.com>
Cc: mttcg@greensocs.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 12/10] tcg: protect TBContext with tb_lock.
Date: Thu, 13 Aug 2015 09:01:41 -0400 (EDT) [thread overview]
Message-ID: <947372426.11934530.1439470901539.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <55CC9422.3070602@greensocs.com>
> > + tb_lock();
> > tb = tb_gen_code(cpu, orig_tb->pc, orig_tb->cs_base, orig_tb->flags,
> > max_cycles | CF_NOCACHE);
>
> tb_gen_code() calls tb_alloc() which calls tb_flush() we end in a double
> tb_lock here.
> But that's probably not really important here as we want to either do a
> tb_flush outside cpu_exec or realloc an other code buffer.
You're right! Honestly I haven't tested tb_flush() at all with these
patches since it's documented as broken with multiple threads.
Luckily the bug is not in the first 10 patches. :)
Paolo
next prev parent reply other threads:[~2015-08-13 13:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 16:40 [Qemu-devel] [PATCH 00/10] translate-all.c thread-safety Paolo Bonzini
2015-08-12 16:40 ` [Qemu-devel] [PATCH 01/10] cpus: protect work list with work_mutex Paolo Bonzini
2015-08-28 14:33 ` Peter Maydell
2015-08-12 16:40 ` [Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variable Paolo Bonzini
2015-08-13 13:05 ` Frederic Konrad
2015-08-13 13:08 ` Paolo Bonzini
2015-08-13 13:19 ` Frederic Konrad
2015-08-28 14:36 ` Peter Maydell
2015-08-29 6:52 ` Paolo Bonzini
2015-08-12 16:40 ` [Qemu-devel] [PATCH 03/10] replace spinlock by QemuMutex Paolo Bonzini
2015-08-13 12:17 ` Frederic Konrad
2015-08-13 13:12 ` Paolo Bonzini
2015-08-13 13:21 ` Frederic Konrad
2015-08-28 14:49 ` Peter Maydell
2015-08-28 14:53 ` Frederic Konrad
2015-08-29 6:51 ` Paolo Bonzini
2015-08-12 16:40 ` [Qemu-devel] [PATCH 04/10] exec-all: remove non-TCG stuff from exec-all.h header Paolo Bonzini
2015-08-28 14:53 ` Peter Maydell
2015-08-29 6:55 ` Paolo Bonzini
2015-08-12 16:40 ` [Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY Paolo Bonzini
2015-08-13 13:14 ` Frederic Konrad
2015-08-13 14:06 ` Paolo Bonzini
2015-08-28 14:56 ` Peter Maydell
2015-08-29 7:07 ` Paolo Bonzini
2015-08-12 16:40 ` [Qemu-devel] [PATCH 06/10] tcg: code_bitmap is not used by user-mode emulation Paolo Bonzini
2015-08-28 14:57 ` Peter Maydell
2015-08-29 7:13 ` Paolo Bonzini
2015-08-12 16:40 ` [Qemu-devel] [PATCH 07/10] tcg: comment on which functions have to be called with mmap_lock held Paolo Bonzini
2015-08-28 15:33 ` Peter Maydell
2015-08-29 6:57 ` Paolo Bonzini
2015-08-12 16:41 ` [Qemu-devel] [PATCH 08/10] tcg: add memory barriers in page_find_alloc accesses Paolo Bonzini
2015-08-12 20:37 ` Emilio G. Cota
2015-08-13 8:13 ` Paolo Bonzini
2015-08-13 19:50 ` Emilio G. Cota
2015-08-28 15:40 ` Peter Maydell
2015-08-29 6:58 ` Paolo Bonzini
2015-08-12 16:41 ` [Qemu-devel] [PATCH 09/10] exec: make mmap_lock/mmap_unlock globally available Paolo Bonzini
2015-08-28 15:42 ` Peter Maydell
2015-08-12 16:41 ` [Qemu-devel] [PATCH 10/10] cpu-exec: fix lock hierarchy for user-mode emulation Paolo Bonzini
2015-08-28 15:59 ` Peter Maydell
2015-08-12 16:41 ` [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held Paolo Bonzini
2015-08-13 12:51 ` Frederic Konrad
2015-08-13 12:59 ` Paolo Bonzini
2015-08-13 13:32 ` Frederic Konrad
2015-08-13 14:39 ` Paolo Bonzini
2015-08-13 15:32 ` Peter Maydell
2015-08-13 16:20 ` Paolo Bonzini
2015-08-12 16:41 ` [Qemu-devel] [PATCH 12/10] tcg: protect TBContext with tb_lock Paolo Bonzini
2015-08-13 12:57 ` Frederic Konrad
2015-08-13 13:01 ` Paolo Bonzini [this message]
2015-08-13 13:04 ` Frederic Konrad
2015-08-14 9:26 ` [Qemu-devel] [PATCH 00/10] translate-all.c thread-safety Frederic Konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=947372426.11934530.1439470901539.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=mttcg@greensocs.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).