From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a4uqc-0002iR-6o
	for qemu-devel@nongnu.org; Fri, 04 Dec 2015 13:12:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a4uqY-0006Au-6M
	for qemu-devel@nongnu.org; Fri, 04 Dec 2015 13:12:46 -0500
Received: from mx6-phx2.redhat.com ([209.132.183.39]:55098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a4uqX-0006Ao-Ux
	for qemu-devel@nongnu.org; Fri, 04 Dec 2015 13:12:42 -0500
Date: Fri, 4 Dec 2015 13:12:36 -0500 (EST)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <948828153.34152037.1449252756022.JavaMail.zimbra@redhat.com>
In-Reply-To: <5661D4BB.50206@openvz.org>
References: <1448900541-19939-1-git-send-email-asmetanin@virtuozzo.com>
	<1448900541-19939-2-git-send-email-asmetanin@virtuozzo.com>
	<565EE292.7010004@redhat.com> <5661A44E.1040503@openvz.org>
	<5661A610.5050401@redhat.com> <5661C566.8000605@openvz.org>
	<5661CF80.7080704@redhat.com> <5661D4BB.50206@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum
	hv_message_type by u32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>, Haiyang Zhang <haiyangz@microsoft.com>, qemu-devel@nongnu.org, Roman Kagan <rkagan@virtuozzo.com>, Andrey Smetanin <asmetanin@virtuozzo.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, "K. Y. Srinivasan" <kys@microsoft.com>


> >> we are now comparing enum with enum which are the same type.
> >> With the change you are proposing we will compare enum
> >> with u32 which are different.
> > This is only an issue in C++.
> >
> >> Original suggestion from Andrey was safe in this respect.
> > Sure, but it makes code less clear.
> >
> > Paolo
> 
> ok, this seems reasonable. Why not to reduce the patch :)
> We'll send an update on Monday.
> 
> Are there any other issue with the patchset?

No, I can also do the change myself. Check kvm/queue.

Paolo