From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V6i5q-0006eG-NK
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 10:18:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V6i5j-00020O-Eu
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 10:18:34 -0400
Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:42780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V6i5j-00020C-9F
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 10:18:27 -0400
Date: Tue, 06 Aug 2013 15:18:13 +0100
From: Alex Bligh <alex@alex.org.uk>
Message-ID: <948F8008F7F6A5018AAD414E@nimrod.local>
In-Reply-To: <20130806135911.GA4373@stefanha-thinkpad.redhat.com>
References: <1375639805-1943-1-git-send-email-alex@alex.org.uk>
	<1375780592-22842-1-git-send-email-alex@alex.org.uk>
	<1375780592-22842-2-git-send-email-alex@alex.org.uk>
	<20130806120218.GB30812@stefanha-thinkpad.redhat.com>
	<5670B9E860CD8E64631E0BE3@nimrod.local>
	<20130806135911.GA4373@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Re: [Qemu-devel] [RFC] [PATCHv6 01/16] aio / timers: add
 qemu-timer.c utility functions
Reply-To: Alex Bligh <alex@alex.org.uk>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Alex Bligh <alex@alex.org.uk>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Stefan,

--On 6 August 2013 15:59:11 +0200 Stefan Hajnoczi <stefanha@gmail.com> 
wrote:

>> --On 6 August 2013 14:02:18 +0200 Stefan Hajnoczi
>> <stefanha@redhat.com> wrote:
>> My preference would be to move these to qemu_clock_deadline_ns (without
>> the INT32_MAX check) and delete the old qemu_clock_deadline routine
>> entirely, but I don't really understand the full set of circumstances
>> in which the qtest routines are meant to work.
>
> Okay, that's excellent.  It would be great to move to a single function.
>
> The way qtest works is that it executes QEMU in a mode that does not run
> guest code.  Instead of running guest code it listens for commands over
> a socket.  The wire protocol can peek/poke memory, notify of interrupts,
> and warp the clock.
>
> There are test cases that use qtest to test emulated devices.
>
> When qtest either steps the clock or sets it to a completely new value
> using qtest_clock_warp() it runs all vm_clock timers that should expire
> before the new time.
>
> Does this help?

Nearly :-)

How do I actually run the code (i.e. how do I test whether I've broken
it)? I take it that's something different from just 'make check'?

-- 
Alex Bligh