From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx
Date: Fri, 20 Jan 2023 08:24:01 +0100 [thread overview]
Message-ID: <9494369d-a498-81f7-0cd8-1cfe31029c2a@redhat.com> (raw)
In-Reply-To: <20230111083909.42624-1-philmd@linaro.org>
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote:
> Since v1:
> - Fix checkpatch style violations
> - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan)
>
> Supersedes: <20230110212947.34557-1-philmd@linaro.org>
> "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx"
>
> Philippe Mathieu-Daudé (4):
> hw: Remove hardcoded tabs (code style)
> bulk: Coding style fixes
> bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx
> bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format
Big sorry, I picked up v1 for my last pull request before I saw that there
is a v2. But IMHO it's ok to have a separate macro with a %016 included, so
I'd rather tend to keep HWADDR_FMT_plx. Anyway, if you consider the other
changes in your series important enough, please rebase them. Sorry again for
the additional work that this might cause.
Thomas
next prev parent reply other threads:[~2023-01-20 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 8:39 [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx Philippe Mathieu-Daudé
2023-01-11 8:39 ` [PATCH v2 1/4] hw: Remove hardcoded tabs (code style) Philippe Mathieu-Daudé
2023-01-11 19:48 ` Richard Henderson
2023-01-11 8:39 ` [PATCH v2 2/4] bulk: Coding style fixes Philippe Mathieu-Daudé
2023-01-11 19:48 ` Richard Henderson
2023-01-18 16:09 ` Thomas Huth
2023-01-18 17:04 ` Philippe Mathieu-Daudé
2023-01-11 8:39 ` [PATCH v2 3/4] bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx Philippe Mathieu-Daudé
2023-01-11 19:50 ` Richard Henderson
2023-01-11 8:39 ` [RFC PATCH v2 4/4] bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format Philippe Mathieu-Daudé
2023-01-20 7:24 ` Thomas Huth [this message]
2023-01-20 9:59 ` [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9494369d-a498-81f7-0cd8-1cfe31029c2a@redhat.com \
--to=thuth@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).