From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 06/13] hw/misc/mps2-scc: Factor out which-board conditionals
Date: Wed, 7 Feb 2024 07:47:39 +1000 [thread overview]
Message-ID: <949bdebc-86b3-4714-8dba-59a3a0b1b920@linaro.org> (raw)
In-Reply-To: <20240206132931.38376-7-peter.maydell@linaro.org>
On 2/6/24 23:29, Peter Maydell wrote:
> The MPS SCC device has a lot of different flavours for the various
> different MPS FPGA images, which look mostly similar but have
> differences in how particular registers are handled. Currently we
> deal with this with a lot of open-coded checks on scc_partno(), but
> as we add more board types this is getting a bit hard to read.
>
> Factor out the conditions into some functions which we can
> give more descriptive names to.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> hw/misc/mps2-scc.c | 45 +++++++++++++++++++++++++++++++--------------
> 1 file changed, 31 insertions(+), 14 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-02-06 21:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 13:29 [PATCH 00/13] hw/arm: Implement new machine mps3-an536 (Cortex-R52 MPS3 AN536 FPGA image) Peter Maydell
2024-02-06 13:29 ` [PATCH 01/13] target/arm: Use new CBAR encoding for all v8 CPUs, not all aarch64 CPUs Peter Maydell
2024-02-06 20:34 ` Richard Henderson
2024-02-06 21:00 ` Peter Maydell
2024-02-06 13:29 ` [PATCH 02/13] target/arm: The Cortex-R52 has a read-only CBAR Peter Maydell
2024-02-06 20:38 ` Richard Henderson
2024-02-06 21:02 ` Peter Maydell
2024-02-06 13:29 ` [PATCH 03/13] target/arm: Add Cortex-R52 IMPDEF sysregs Peter Maydell
2024-02-06 22:21 ` Richard Henderson
2024-02-06 13:29 ` [PATCH 04/13] target/arm: Allow access to SPSR_hyp from hyp mode Peter Maydell
2024-02-06 21:46 ` Richard Henderson
2024-02-06 13:29 ` [PATCH 05/13] hw/misc/mps2-scc: Fix condition for CFG3 register Peter Maydell
2024-02-06 15:52 ` Philippe Mathieu-Daudé
2024-02-06 21:47 ` Richard Henderson
2024-02-06 13:29 ` [PATCH 06/13] hw/misc/mps2-scc: Factor out which-board conditionals Peter Maydell
2024-02-06 15:56 ` Philippe Mathieu-Daudé
2024-02-06 21:47 ` Richard Henderson [this message]
2024-02-07 8:47 ` Philippe Mathieu-Daudé
2024-02-06 13:29 ` [PATCH 07/13] hw/misc/mps2-scc: Make changes needed for AN536 FPGA image Peter Maydell
2024-02-06 21:50 ` Richard Henderson
2024-02-07 8:56 ` Philippe Mathieu-Daudé
2024-02-06 13:29 ` [PATCH 08/13] hw/arm/mps3r: Initial skeleton for mps3-an536 board Peter Maydell
2024-02-06 19:21 ` Philippe Mathieu-Daudé
2024-02-06 20:57 ` Peter Maydell
2024-02-07 9:02 ` Philippe Mathieu-Daudé
2024-02-08 17:02 ` Peter Maydell
2024-02-08 17:07 ` Cédric Le Goater
2024-02-08 18:19 ` Philippe Mathieu-Daudé
2024-02-06 13:29 ` [PATCH 09/13] hw/arm/mps3r: Add CPUs, GIC, and per-CPU RAM Peter Maydell
2024-02-15 17:53 ` Alex Bennée
2024-02-06 13:29 ` [PATCH 10/13] hw/arm/mps3r: Add UARTs Peter Maydell
2024-02-06 16:44 ` Philippe Mathieu-Daudé
2024-02-06 13:29 ` [PATCH 11/13] hw/arm/mps3r: Add GPIO, watchdog, dual-timer, I2C devices Peter Maydell
2024-02-06 16:47 ` Philippe Mathieu-Daudé
2024-02-06 13:29 ` [PATCH 12/13] hw/arm/mps3r: Add remaining devices Peter Maydell
2024-02-06 16:49 ` Philippe Mathieu-Daudé
2024-02-06 13:29 ` [PATCH 13/13] docs: Add documentation for the mps3-an536 board Peter Maydell
2024-02-06 16:50 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949bdebc-86b3-4714-8dba-59a3a0b1b920@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).