qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Felipe Contreras" <felipe.contreras@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] possible mmap regression
Date: Tue, 12 Feb 2008 21:42:15 +0200	[thread overview]
Message-ID: <94a0d4530802121142xd7987d7k31cd74b488882d19@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi,

I don't know what I'm doing but this seems to fix the weird issue I was having.
http://article.gmane.org/gmane.comp.emulators.qemu/23314

I've found out that this happens on linux 2.6.23, but not 2.6.24.

Cheers.

-- 
Felipe Contreras

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: qemu-mmap-fix.diff --]
[-- Type: text/x-patch; name=qemu-mmap-fix.diff, Size: 608 bytes --]

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 6292826..3050ad9 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -251,7 +251,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
            especially important if qemu_host_page_size >
            qemu_real_host_page_size */
         p = mmap(g2h(mmap_start),
-                 host_len, prot, flags | MAP_FIXED, fd, host_offset);
+                 host_len, prot, flags, fd, host_offset);
         if (p == MAP_FAILED)
             return -1;
         /* update start so that it points to the file position at 'offset' */

             reply	other threads:[~2008-02-12 19:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 19:42 Felipe Contreras [this message]
2008-02-16 21:07 ` [Qemu-devel] [PATCH] possible mmap regression Edgar E. Iglesias
2008-02-20 13:03   ` Felipe Contreras
2008-02-20 13:13     ` Edgar E. Iglesias
2008-02-20 13:22       ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94a0d4530802121142xd7987d7k31cd74b488882d19@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).