From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JSqD8-0000Dk-3u
	for qemu-devel@nongnu.org; Sat, 23 Feb 2008 03:58:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JSqD5-0000DX-Dl
	for qemu-devel@nongnu.org; Sat, 23 Feb 2008 03:58:20 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JSqD5-0000DU-41
	for qemu-devel@nongnu.org; Sat, 23 Feb 2008 03:58:19 -0500
Received: from mx20.gnu.org ([199.232.41.8])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <felipe.contreras@gmail.com>)
	id 1JSqD4-0004pb-HM
	for qemu-devel@nongnu.org; Sat, 23 Feb 2008 03:58:18 -0500
Received: from rv-out-0910.google.com ([209.85.198.186])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <felipe.contreras@gmail.com>) id 1JSqD3-0000sx-8U
	for qemu-devel@nongnu.org; Sat, 23 Feb 2008 03:58:17 -0500
Received: by rv-out-0910.google.com with SMTP id g11so1437980rvb.22
	for <qemu-devel@nongnu.org>; Sat, 23 Feb 2008 00:58:12 -0800 (PST)
Message-ID: <94a0d4530802230058o773bf28eq21f021c7b7c50d0a@mail.gmail.com>
Date: Sat, 23 Feb 2008 10:58:12 +0200
From: "Felipe Contreras" <felipe.contreras@gmail.com>
In-Reply-To: <20080222153235.GB16991@edgar.se.axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080222153235.GB16991@edgar.se.axis.com>
Subject: [Qemu-devel] Re: [PATCH] linux-user/mmap v3: Testsuite + bugfixes
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Cc: qemu-devel@nongnu.org

On Fri, Feb 22, 2008 at 5:32 PM, Edgar E. Iglesias
<edgar.iglesias@axis.com> wrote:
> Hi,
>
>  This is the third version of the linux-user/mmap bugfix patches:
>
>  * Let the native mmap choose addresses for unfixed mappings.
>  * For file mappings, correct mapping of pages beyond EOF.
>  * Adds a small testsuite for linux-user/mmap.
>
>  Tested with test-mmap for CRIS, MIPS, ARM and i386, simulated on linux-i686
>   hosts.
>
>  Felipe, I think the problems you are seeing are related to large mmaps failing. By letting the native mmap choose the addresses for unfixed mmaps, I hope your segfaults will go away.

This patch does fix the weird issues I was having.

Does the test checks for the issues I had?

-- 
Felipe Contreras