From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 07/12] python: update help text for check-tox
Date: Tue, 29 Jun 2021 13:51:04 -0300 [thread overview]
Message-ID: <94a1d206-190c-3605-513f-ee073928141f@redhat.com> (raw)
In-Reply-To: <20210629164253.1272763-8-jsnow@redhat.com>
On 6/29/21 1:42 PM, John Snow wrote:
> Move it up near the check-pipenv help text, and update it to suggest parity.
>
> (At the time I first added it, I wasn't sure if I would be keeping it,
> but I've come to appreciate it as it has actually helped uncover bugs I
> would not have noticed without it. It should stay.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> ---
> python/Makefile | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/python/Makefile b/python/Makefile
> index 07ad73ccd0..d2cfa6ad8f 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -9,13 +9,17 @@ help:
> @echo " Requires: Python 3.6 and pipenv."
> @echo " Hint (Fedora): 'sudo dnf install python3.6 pipenv'"
> @echo ""
> + @echo "make check-tox:"
> + @echo " Run tests against multiple python versions."
> + @echo " These tests use the newest dependencies."
> + @echo " Requires: Python 3.6 - 3.10, and tox."
> + @echo " Hint (Fedora): 'sudo dnf install python3-tox python3.10'"
> + @echo ""
> @echo "make develop: Install deps for 'make check', and"
> @echo " the qemu libs in editable/development mode."
> @echo ""
> @echo "make check: run linters using the current environment."
> @echo ""
> - @echo "make check-tox: run linters using multiple python versions."
> - @echo ""
> @echo "make pipenv"
> @echo " Creates pipenv's virtual environment (.venv)"
> @echo ""
next prev parent reply other threads:[~2021-06-29 16:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 16:42 [PATCH v2 00/12] Python: packaging cleanups John Snow
2021-06-29 16:42 ` [PATCH v2 01/12] python: expose typing information via PEP 561 John Snow
2021-06-29 16:42 ` [PATCH v2 02/12] python: Remove global pylint suppressions John Snow
2021-06-29 16:42 ` [PATCH v2 03/12] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-06-29 16:42 ` [PATCH v2 04/12] python: README.rst touchups John Snow
2021-06-29 16:42 ` [PATCH v2 05/12] python: Add no-install usage instructions John Snow
2021-06-29 16:42 ` [PATCH v2 06/12] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-06-29 16:42 ` [PATCH v2 07/12] python: update help text for check-tox John Snow
2021-06-29 16:51 ` Wainer dos Santos Moschetta [this message]
2021-06-29 20:23 ` Wainer dos Santos Moschetta
2021-06-29 21:27 ` John Snow
2021-06-30 18:55 ` Wainer dos Santos Moschetta
2021-06-29 16:42 ` [PATCH v2 08/12] python: Fix .PHONY Make specifiers John Snow
2021-06-29 16:53 ` Wainer dos Santos Moschetta
2021-06-29 18:06 ` Willian Rampazzo
2021-06-29 16:42 ` [PATCH v2 09/12] python: add 'make check-dev' invocation John Snow
2021-06-29 17:34 ` Wainer dos Santos Moschetta
2021-06-29 17:43 ` John Snow
2021-06-29 16:42 ` [PATCH v2 10/12] python: Update help text on 'make check', 'make develop' John Snow
2021-06-29 16:42 ` [PATCH v2 11/12] python: Update help text on 'make clean', 'make distclean' John Snow
2021-06-29 16:42 ` [PATCH v2 12/12] python: remove auto-generated pyproject.toml file John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a1d206-190c-3605-513f-ee073928141f@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).