From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C839C3524A for ; Tue, 4 Feb 2020 08:17:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD17B2087E for ; Tue, 4 Feb 2020 08:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KbAmWUGO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD17B2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iytOp-00088T-Ne for qemu-devel@archiver.kernel.org; Tue, 04 Feb 2020 03:17:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54098) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iytNQ-0007JN-O4 for qemu-devel@nongnu.org; Tue, 04 Feb 2020 03:16:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iytNP-00052L-D4 for qemu-devel@nongnu.org; Tue, 04 Feb 2020 03:16:08 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41242 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iytNP-0004vr-7C for qemu-devel@nongnu.org; Tue, 04 Feb 2020 03:16:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580804161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m1gTaXDdNJNB2A5jcQ3YU4Ea6LKj1t8cnZY8haZ1EDc=; b=KbAmWUGOyKJfrPz7JxA+oa9nRpdgnI2xhM31694VxFXPNtpAxdDZ4O1I70wQb6vibZTP0d RiFN+LrMB+fVWlDyRQFqd5OnHSeNjPi1kSCz/uSVz1/83J3/urnJ3GcjmObS1ZuVvOEizj GZW81jySehEltmyhD1CMcU1jd6MkE6k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-s0keQ79yM2i0YkItZtyqkw-1; Tue, 04 Feb 2020 03:15:55 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 72F9D8010E6; Tue, 4 Feb 2020 08:15:54 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25D531001B28; Tue, 4 Feb 2020 08:15:49 +0000 (UTC) Message-ID: <94ba85dcc5213d386a55706a7bdbb507cfe64d8f.camel@redhat.com> Subject: Re: [PATCH v4 00/11] RFC: [for 5.0]: HMP monitor handlers refactoring From: Maxim Levitsky To: "Dr. David Alan Gilbert" Date: Tue, 04 Feb 2020 10:15:49 +0200 In-Reply-To: <20200203195758.GQ2822@work-vm> References: <20200130123448.21093-1-mlevitsk@redhat.com> <20200203195758.GQ2822@work-vm> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: s0keQ79yM2i0YkItZtyqkw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Gerd Hoffmann , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 2020-02-03 at 19:57 +0000, Dr. David Alan Gilbert wrote: > * Maxim Levitsky (mlevitsk@redhat.com) wrote: > > This patch series is bunch of cleanups to the hmp monitor code. > > It mostly moves the blockdev related hmp handlers to its own file, > > and does some minor refactoring. > > > > No functional changes expected. > > You've still got the title marked as RFC - are you actually ready for > this log? I forgot to update this to be honest, I don't consider this an RFC, especially since I dropped for now the patches that might cause issues. This is now just a nice refactoring. Best regards, Maxim Levitsky > > Dave > > > > > Changes from V1: > > * move the handlers to block/monitor/block-hmp-cmds.c > > * tiny cleanup for the commit messages > > > > Changes from V2: > > * Moved all the function prototypes to new header (blockdev-hmp-cmds.h) > > * Set the license of blockdev-hmp-cmds.c to GPLv2+ > > * Moved hmp_snapshot_* functions to blockdev-hmp-cmds.c > > * Moved hmp_drive_add_node to blockdev-hmp-cmds.c > > (this change needed some new exports, thus in separate new patch) > > * Moved hmp_qemu_io and hmp_eject to blockdev-hmp-cmds.c > > * Added 'error:' prefix to vreport, and updated the iotests > > This is invasive change, but really feels like the right one > > * Added minor refactoring patch that drops an unused #include > > > > Changes from V3: > > * Dropped the error prefix patches for now due to fact that it seems > > that libvirt doesn't need that after all. Oh well... > > I'll send them in a separate series. > > > > * Hopefully correctly merged the copyright info the new files > > Both files are GPLv2 now (due to code from hmp.h/hmp-cmds.c) > > > > * Addressed review feedback > > * Renamed the added header to block-hmp-cmds.h > > > > * Got rid of checkpatch.pl warnings in the moved code > > (cosmetic code changes only) > > > > * I kept the reviewed-by tags, since the changes I did are minor. > > I hope that this is right thing to do. > > > > Best regards, > > Maxim Levitsky > > > > Maxim Levitsky (11): > > usb/dev-storage: remove unused include > > monitor/hmp: uninline add_init_drive > > monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c > > monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c > > monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to > > block-hmp-cmds.c Moved code was added after 2012-01-13, thus under > > GPLv2+ > > monitor/hmp: move hmp_block_job* to block-hmp-cmds.c > > monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c > > hmp_snapshot_blkdev is from GPLv2 version of the hmp-cmds.c thus > > have to change the licence to GPLv2 > > monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c > > monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c > > monitor/hmp: move hmp_info_block* to block-hmp-cmds.c > > monitor/hmp: Move hmp_drive_add_node to block-hmp-cmds.c > > > > MAINTAINERS | 1 + > > Makefile.objs | 2 +- > > block/Makefile.objs | 1 + > > block/monitor/Makefile.objs | 1 + > > block/monitor/block-hmp-cmds.c | 1002 ++++++++++++++++++++++++++++++++ > > blockdev.c | 137 +---- > > device-hotplug.c | 91 --- > > hw/usb/dev-storage.c | 1 - > > include/block/block-hmp-cmds.h | 54 ++ > > include/block/block_int.h | 5 +- > > include/monitor/hmp.h | 24 - > > include/sysemu/blockdev.h | 4 - > > include/sysemu/sysemu.h | 3 - > > monitor/hmp-cmds.c | 769 ------------------------ > > monitor/misc.c | 1 + > > 15 files changed, 1072 insertions(+), 1024 deletions(-) > > create mode 100644 block/monitor/Makefile.objs > > create mode 100644 block/monitor/block-hmp-cmds.c > > delete mode 100644 device-hotplug.c > > create mode 100644 include/block/block-hmp-cmds.h > > > > -- > > 2.17.2 > > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK