Re: [PATCH 2/2] hw/ppc: Fix memory leak in get_cpu_state_data()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi Shivang,

On 28/10/25 07:58, Shivang Upadhyay wrote:
> Fixes coverity (CID 1642024)
> 
> Cc: Aditya Gupta <adityag@linux.ibm.com>
> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
> Link: https://lore.kernel.org/qemu-devel/CAFEAcA_Bm52bkPi9MH_uugXRR5fj48RtpbOnPNFQtbX=7Mz_yw@mail.gmail.com/
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---
>   hw/ppc/spapr_fadump.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
> index 883a60cdcf..49d2f862a1 100644
> --- a/hw/ppc/spapr_fadump.c
> +++ b/hw/ppc/spapr_fadump.c
> @@ -453,7 +453,7 @@ static FadumpRegEntry *populate_cpu_reg_entries(CPUState *cpu,
>   static void *get_cpu_state_data(uint64_t *cpu_state_len)
>   {
>       FadumpRegSaveAreaHeader reg_save_hdr;
> -    FadumpRegEntry *reg_entries;
> +    g_autofree FadumpRegEntry *reg_entries;

g_autofree pointers have to be NULL-initialized. I don't remember why,
likely CPP warnings.

>       FadumpRegEntry *curr_reg_entry;
>       CPUState *cpu;
>