From: Zhang Wen <zhw2101024@gmail.com>
To: qemu-trivial@nongnu.org
Cc: pbonzini@redhat.com, marcandre.lureau@redhat.com,
berrange@redhat.com, thuth@redhat.com, philmd@linaro.org,
qemu-devel@nongnu.org
Subject: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump
Date: Wed, 31 Jan 2024 16:13:30 +0800 [thread overview]
Message-ID: <94cf974b-05ec-41c2-8d0b-43ffbc8bdeac@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
With this patch, qemu requires keyboard-config when libxkbcommon is
found on the system. So if the qemu is configured when libxkbcommon is
installed but not keyboard-config, the configure stage will produce an
error message, thus avoid coredump in the build stage.
[-- Attachment #2: 0001-requires-xkeyboard-config-when-libxkbcommon-is-avail.patch --]
[-- Type: text/plain, Size: 1213 bytes --]
From e0b1e479e8a82f7a7940ca70b5136bf10e36756b Mon Sep 17 00:00:00 2001
From: Zhang Wen <zhw2101024@gmail.com>
Date: Fri, 26 Jan 2024 17:09:10 +0800
Subject: [PATCH] requires xkeyboard-config when libxkbcommon is available to
avoid build error
Signed-off-by: Zhang Wen <zhw2101024@gmail.com>
---
meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index d0329966f1..233c006754 100644
--- a/meson.build
+++ b/meson.build
@@ -1093,6 +1093,7 @@ else
xkbcommon = dependency('xkbcommon', required: get_option('xkbcommon'),
method: 'pkg-config')
endif
+xkeyboard_config = dependency('xkeyboard-config')
slirp = not_found
if not get_option('slirp').auto() or have_system
@@ -3978,7 +3979,7 @@ subdir('qga')
if xkbcommon.found()
# used for the update-keymaps target, so include rules even if !have_tools
qemu_keymap = executable('qemu-keymap', files('qemu-keymap.c', 'ui/input-keymap.c') + genh,
- dependencies: [qemuutil, xkbcommon], install: have_tools)
+ dependencies: [qemuutil, xkbcommon, xkeyboard_config], install: have_tools)
endif
if have_tools
--
2.43.0
next reply other threads:[~2024-01-31 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:13 Zhang Wen [this message]
2024-02-01 12:11 ` building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump Michael Tokarev
2024-02-01 12:49 ` Michael Tokarev
2024-02-01 12:57 ` Peter Maydell
2024-02-01 12:59 ` Michael Tokarev
2024-02-06 6:35 ` Zhang Wen
2024-02-06 7:08 ` Michael Tokarev
2024-02-06 7:50 ` Zhang Wen
2024-02-08 2:00 ` Zhang Wen
2024-02-08 11:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94cf974b-05ec-41c2-8d0b-43ffbc8bdeac@gmail.com \
--to=zhw2101024@gmail.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).