From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FFF2EB64D7 for ; Wed, 21 Jun 2023 17:08:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qC1JH-0007d6-2O; Wed, 21 Jun 2023 13:07:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qC1JG-0007aQ-3n; Wed, 21 Jun 2023 13:07:58 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qC1JD-00076x-LY; Wed, 21 Jun 2023 13:07:57 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4QmVLZ3m8zz4x07; Thu, 22 Jun 2023 03:07:50 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QmVLX69kgz4wjF; Thu, 22 Jun 2023 03:07:48 +1000 (AEST) Message-ID: <94e3706b-2649-3c7d-7b48-c96d116a9326@kaod.org> Date: Wed, 21 Jun 2023 19:07:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] pnv/xive2: Add a get_config() method on the presenter class Content-Language: en-US To: Frederic Barrat , danielhb413@gmail.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org References: <20230621160306.896045-1-fbarrat@linux.ibm.com> <20230621160306.896045-2-fbarrat@linux.ibm.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20230621160306.896045-2-fbarrat@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=5utS=CJ=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.093, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/21/23 18:03, Frederic Barrat wrote: > The presenters for xive on P9 and P10 are mostly similar but the > behavior can be tuned through a few CQ registers. This patch adds a > "get_config" method, which will allow to access that config from the > presenter in a later patch. > For now, just define the config for the TIMA version. > > Signed-off-by: Frederic Barrat Looks good. If I remember well, each XIVE subunit has a copy of the config registers and modifications to the CQ unit are spanned to the others. Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/intc/pnv_xive.c | 11 +++++++++++ > hw/intc/pnv_xive2.c | 12 ++++++++++++ > hw/intc/xive.c | 7 +++++++ > include/hw/ppc/xive.h | 3 +++ > 4 files changed, 33 insertions(+) > > diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c > index 622f9d28b7..e536b3ec26 100644 > --- a/hw/intc/pnv_xive.c > +++ b/hw/intc/pnv_xive.c > @@ -479,6 +479,16 @@ static int pnv_xive_match_nvt(XivePresenter *xptr, uint8_t format, > return count; > } > > +static uint32_t pnv_xive_presenter_get_config(XivePresenter *xptr) > +{ > + uint32_t cfg = 0; > + > + /* TIMA GEN1 is all P9 knows */ > + cfg |= XIVE_PRESENTER_GEN1_TIMA_OS; > + > + return cfg; > +} > + > static uint8_t pnv_xive_get_block_id(XiveRouter *xrtr) > { > return pnv_xive_block_id(PNV_XIVE(xrtr)); > @@ -1991,6 +2001,7 @@ static void pnv_xive_class_init(ObjectClass *klass, void *data) > > xnc->notify = pnv_xive_notify; > xpc->match_nvt = pnv_xive_match_nvt; > + xpc->get_config = pnv_xive_presenter_get_config; > }; > > static const TypeInfo pnv_xive_info = { > diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c > index ec1edeb385..59534f6843 100644 > --- a/hw/intc/pnv_xive2.c > +++ b/hw/intc/pnv_xive2.c > @@ -501,6 +501,17 @@ static int pnv_xive2_match_nvt(XivePresenter *xptr, uint8_t format, > return count; > } > > +static uint32_t pnv_xive2_presenter_get_config(XivePresenter *xptr) > +{ > + PnvXive2 *xive = PNV_XIVE2(xptr); > + uint32_t cfg = 0; > + > + if (xive->cq_regs[CQ_XIVE_CFG >> 3] & CQ_XIVE_CFG_GEN1_TIMA_OS) { > + cfg |= XIVE_PRESENTER_GEN1_TIMA_OS; > + } > + return cfg; > +} > + > static uint8_t pnv_xive2_get_block_id(Xive2Router *xrtr) > { > return pnv_xive2_block_id(PNV_XIVE2(xrtr)); > @@ -1987,6 +1998,7 @@ static void pnv_xive2_class_init(ObjectClass *klass, void *data) > xnc->notify = pnv_xive2_notify; > > xpc->match_nvt = pnv_xive2_match_nvt; > + xpc->get_config = pnv_xive2_presenter_get_config; > }; > > static const TypeInfo pnv_xive2_info = { > diff --git a/hw/intc/xive.c b/hw/intc/xive.c > index 5204c14b87..34a868b185 100644 > --- a/hw/intc/xive.c > +++ b/hw/intc/xive.c > @@ -461,6 +461,13 @@ static void xive_tm_push_os_ctx(XivePresenter *xptr, XiveTCTX *tctx, > } > } > > +static __attribute__((unused)) uint32_t xive_presenter_get_config(XivePresenter *xptr) > +{ > + XivePresenterClass *xpc = XIVE_PRESENTER_GET_CLASS(xptr); > + > + return xpc->get_config(xptr); > +} > + > /* > * Define a mapping of "special" operations depending on the TIMA page > * offset and the size of the operation. > diff --git a/include/hw/ppc/xive.h b/include/hw/ppc/xive.h > index f7eea4ca81..3dfb06e002 100644 > --- a/include/hw/ppc/xive.h > +++ b/include/hw/ppc/xive.h > @@ -430,6 +430,8 @@ typedef struct XivePresenterClass XivePresenterClass; > DECLARE_CLASS_CHECKERS(XivePresenterClass, XIVE_PRESENTER, > TYPE_XIVE_PRESENTER) > > +#define XIVE_PRESENTER_GEN1_TIMA_OS 0x1 > + > struct XivePresenterClass { > InterfaceClass parent; > int (*match_nvt)(XivePresenter *xptr, uint8_t format, > @@ -437,6 +439,7 @@ struct XivePresenterClass { > bool cam_ignore, uint8_t priority, > uint32_t logic_serv, XiveTCTXMatch *match); > bool (*in_kernel)(const XivePresenter *xptr); > + uint32_t (*get_config)(XivePresenter *xptr); > }; > > int xive_presenter_tctx_match(XivePresenter *xptr, XiveTCTX *tctx,