From: Eric Blake <eblake@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Corey Minyard <cminyard@mvista.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, minyard@acm.org,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH for-3.1?] pc:piix4: Update smbus I/O space after a migration
Date: Thu, 29 Nov 2018 10:43:50 -0600 [thread overview]
Message-ID: <94fea825-f77b-760f-d093-eccc137594d8@redhat.com> (raw)
In-Reply-To: <20181129104930-mutt-send-email-mst@kernel.org>
On 11/29/18 9:49 AM, Michael S. Tsirkin wrote:
> On Thu, Nov 29, 2018 at 09:45:17AM -0600, Corey Minyard wrote:
>> On 11/26/18 12:28 PM, minyard@acm.org wrote:
>>> From: Corey Minyard <cminyard@mvista.com>
>>>
>>> Otherwise it won't be set up correctly and won't work after
>>> miigration.
>>
>> Any opinions on this? I think this would be good for 3.1. Without
>> this when a migration occurs on piix4 the SMBus address space
>> appears in the wrong place. I'm not sure how bad that is, but
>> SMBus certainly ceases to work.
>>
>> -corey
>
>
> I have this queued. Thanks!
We've missed -rc3. Is the problem this patch addresses severe enough to
warrant -rc4? Is it a regression since 3.0?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-11-29 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 18:28 [Qemu-devel] [PATCH] pc:piix4: Update smbus I/O space after a migration minyard
2018-11-29 15:45 ` Corey Minyard
2018-11-29 15:49 ` Michael S. Tsirkin
2018-11-29 16:43 ` Eric Blake [this message]
2018-12-03 15:14 ` [Qemu-devel] [PATCH for-3.1?] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94fea825-f77b-760f-d093-eccc137594d8@redhat.com \
--to=eblake@redhat.com \
--cc=cminyard@mvista.com \
--cc=imammedo@redhat.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).