qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Nicholas Piggin <npiggin@gmail.com>,
	Harsh Prateek Bora <harshpb@linux.ibm.com>
Subject: Re: [PATCH] tests/functional: Update the ppc64 pseries and pnv tests
Date: Wed, 26 Feb 2025 09:11:21 +0100	[thread overview]
Message-ID: <9500f130-c3b4-44c0-b51a-070429756a36@redhat.com> (raw)
In-Reply-To: <cb6e9bb4-5eee-4492-abe0-073ecf586267@redhat.com>

On 26/02/2025 08.54, Cédric Le Goater wrote:
> On 2/26/25 08:01, Thomas Huth wrote:
>> On 26/02/2025 07.54, Cédric Le Goater wrote:
>>> The tests are using a now archived Fedora29 release. Switch to the
>>> most recent Fedora41 release.
>>>
>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>> ---
>>>   tests/functional/test_ppc64_powernv.py | 6 +++---
>>>   tests/functional/test_ppc64_pseries.py | 6 +++---
>>>   2 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/tests/functional/test_ppc64_powernv.py b/tests/functional/ 
>>> test_ppc64_powernv.py
>>> index 685e2178ed78..a9da7905366e 100755
>>> --- a/tests/functional/test_ppc64_powernv.py
>>> +++ b/tests/functional/test_ppc64_powernv.py
>>> @@ -18,9 +18,9 @@ class powernvMachine(LinuxKernelTest):
>>>       good_message = 'VFS: Cannot open root device'
>>>       ASSET_KERNEL = Asset(
>>> -        ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
>>> -         'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>> -        '383c2f5c23bc0d9d32680c3924d3fd7ee25cc5ef97091ac1aa5e1d853422fc5f')
>>> +        ('https://archives.fedoraproject.org/pub/fedora-secondary/'
>>> +         'releases/41/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
>>> +        'eca627adbe42437cacea169beeb4c3c12a5cfbca1a6b1ba5218d28139d2143c4')
>>
>> I think we should rather avoid the very latest and greatest Fedora URLs 
>> here... they will be invalid in a couple of months after Fedora 43 has 
>> been released. And if we keep switching the test assets all the time, this 
>> will make it more difficult to bisect regressions in the future.
>>
>>   Thomas
>>
> 
> So we should point to the latest archive (fedora38) then ?

Either that, or simply keep the f29 kernel ... what do we gain by switching 
to a newer one here? Is it testing more hardware?

  Thomas



  reply	other threads:[~2025-02-26  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  6:54 [PATCH] tests/functional: Update the ppc64 pseries and pnv tests Cédric Le Goater
2025-02-26  7:01 ` Thomas Huth
2025-02-26  7:54   ` Cédric Le Goater
2025-02-26  8:11     ` Thomas Huth [this message]
2025-02-26  8:18       ` Cédric Le Goater
2025-02-26  9:04   ` Daniel P. Berrangé
2025-02-26 16:34     ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9500f130-c3b4-44c0-b51a-070429756a36@redhat.com \
    --to=thuth@redhat.com \
    --cc=clg@redhat.com \
    --cc=harshpb@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).