From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AED69D2B92B for ; Tue, 5 Nov 2024 13:44:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8Jqq-00031k-13; Tue, 05 Nov 2024 08:44:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8Jqo-00031T-Gd for qemu-devel@nongnu.org; Tue, 05 Nov 2024 08:44:06 -0500 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8Jqm-0000Ur-RB for qemu-devel@nongnu.org; Tue, 05 Nov 2024 08:44:06 -0500 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a9a4031f69fso875836566b.0 for ; Tue, 05 Nov 2024 05:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730814243; x=1731419043; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=40G9pr3QBzMc2KOpvJ6PeZ8hO4T9az3q3ckT6Oy74kU=; b=cBUyz4Z9TsBkNaG9NBciu/arL0RmeUc+NaVCNHzQLP00Ke7uT2H0/fg1RrOt8zAzZo SRc9gu3W5xSnHCWYiSa3PVQCGTV+eSn1SfG975IlmnOK/OSNNWWKMuC84lNZTOmnkg1H SG3Yr4NnE5/Gx2GFe/CKNiEmPBaOFTDL5e/irg3Ep8HM7dZglGzPqZo6YoG8TcTV7ZR5 RrRCCNjVVQEOEAjRbZKbOo6hakOKno3jb59nb+fLLTbUEUHxXuJ75KRwvaMMV2/s5+1X IeHdLjEinFazI/rn8XEE4x03kBXdpibFfA121if+nlwG3v60NAoWRGp1ks3nkIMbOw4T Hl9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730814243; x=1731419043; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=40G9pr3QBzMc2KOpvJ6PeZ8hO4T9az3q3ckT6Oy74kU=; b=rt5uWhoaZTSlqHiJBBX1MG9+bPpwCkIHQsPkrvDVPklp/LVVmTnXw6LNB8ncTxOWb9 0obOL+4Ta5lvHf1WLtkuupGfs6YikkYo+XoiUxPvkLFUq+vjhGoqOCAXSOFRt6+kWMkM PgBl0I631+BI9BKEtbQ0WWpPqqw9eR4pRdw89b451F1Iq2yZISQilpu0d0gWpu/jFuVf SyoNUsMpy0RV9EsJdy+uJd8qkT+KyH07MzeIDVafAWEynuxdGIV7tjAK0uA4dTFZJUYb w8/sjxdka3uJzNaq9Ti46h/JzEYhe4DBZtX9IhPLvHwUX+MkyZGFjoox4r/eWxzF8/8J 3dpA== X-Forwarded-Encrypted: i=1; AJvYcCUq5y6MOuflabjxQMUWCIRmQlczNzKh4h0NbMUe+D1slhOD6tzokig/QZdG46rUOS2BhjDPbt1iRZzL@nongnu.org X-Gm-Message-State: AOJu0YwmWiE1qv6WnJMA3uq5MlsGyqfHi6ceJwnl2m4FU/Ac6IYZM5Yv BZ7hHzcYWURtck6xlEHe5uE3+5xsvZq/GMrTuxQXp5SHI29eksEcXt75W/qIvl3lRsKY3w819yl o+1s= X-Google-Smtp-Source: AGHT+IGQ3dO5oKKG0w25XViEM3Qt3h0oeuZQROOxE4XtGTUtG3FSuwXUY81NAWuwTjkgwtPJcvkWRw== X-Received: by 2002:a17:906:f889:b0:a9e:6712:c27 with SMTP id a640c23a62f3a-a9e67120e0dmr1261536966b.49.1730814242789; Tue, 05 Nov 2024 05:44:02 -0800 (PST) Received: from [192.168.21.227] ([89.101.134.25]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9eb169fa0dsm135635166b.17.2024.11.05.05.44.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2024 05:44:02 -0800 (PST) Message-ID: <95438667-18ee-450f-8d1f-69bf6b898651@linaro.org> Date: Tue, 5 Nov 2024 13:43:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/19] hw/microblaze: Support various endianness for s3adsp1800 machines To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Anton Johansson Cc: "Edgar E. Iglesias" , Peter Maydell , Alistair Francis , Thomas Huth , qemu-arm@nongnu.org, devel@lists.libvirt.org, =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Jason Wang References: <20241105130431.22564-1-philmd@linaro.org> <20241105130431.22564-18-philmd@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20241105130431.22564-18-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/5/24 13:04, Philippe Mathieu-Daudé wrote: > -static void petalogix_s3adsp1800_machine_class_init(ObjectClass *oc, void *data) > +static void petalogix_s3adsp1800_machine_class_init_be(ObjectClass *oc, void *data) > { > MachineClass *mc = MACHINE_CLASS(oc); > + PetalogixS3adsp1800MachineClass *pmc = PETALOGIX_S3ADSP1800_MACHINE_CLASS(oc); > > - mc->desc = "PetaLogix linux refdesign for xilinx Spartan 3ADSP1800"; > + pmc->little_endian = false; > + mc->desc = "PetaLogix linux refdesign for xilinx Spartan 3ADSP1800 (big endian)"; > mc->init = petalogix_s3adsp1800_init; > +#if TARGET_BIG_ENDIAN > mc->is_default = true; > + mc->alias = "petalogix-s3adsp1800"; > +#endif > +} > + > +static void petalogix_s3adsp1800_machine_class_init_le(ObjectClass *oc, void *data) > +{ > + MachineClass *mc = MACHINE_CLASS(oc); > + PetalogixS3adsp1800MachineClass *pmc = PETALOGIX_S3ADSP1800_MACHINE_CLASS(oc); > + > + pmc->little_endian = true; > + mc->desc = "PetaLogix linux refdesign for xilinx Spartan 3ADSP1800 (little endian)"; > + mc->init = petalogix_s3adsp1800_init; > +#if !TARGET_BIG_ENDIAN > + mc->is_default = true; > + mc->alias = "petalogix-s3adsp1800"; > +#endif > } These can be C if's, instead of preprocessor #if, at which point you can share code. static void petalogix_s3adsp1800_machine_class_init(ObjectClass *oc, bool little_endian) { MachineClass *mc = MACHINE_CLASS(oc); PetalogixS3adsp1800MachineClass *pmc = PETALOGIX_S3ADSP1800_MACHINE_CLASS(oc); mc->init = petalogix_s3adsp1800_init; pmc->little_endian = little_endian; mc->desc = little_endian ? "PetaLogix linux refdesign for xilinx Spartan 3ADSP1800 (little endian)" : "PetaLogix linux refdesign for xilinx Spartan 3ADSP1800 (big endian)"; if (little_endian == !TARGET_BIG_ENDIAN) { mc->is_default = true; mc->alias = "petalogix-s3adsp1800"; } } static void petalogix_s3adsp1800_machine_class_init_be(ObjectClass *oc, void *data) { petalogix_s3adsp1800_machine_class_init(oc, false); } With that, Reviewed-by: Richard Henderson r~