From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03520C2BA83 for ; Wed, 12 Feb 2020 09:10:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C35DA206CC for ; Wed, 12 Feb 2020 09:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SAAtBd26" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C35DA206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1o2o-0004CR-K3 for qemu-devel@archiver.kernel.org; Wed, 12 Feb 2020 04:10:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43813) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1o1k-000336-Lg for qemu-devel@nongnu.org; Wed, 12 Feb 2020 04:09:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1o1j-0008HM-MD for qemu-devel@nongnu.org; Wed, 12 Feb 2020 04:09:48 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44316 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1o1j-0008H7-JB for qemu-devel@nongnu.org; Wed, 12 Feb 2020 04:09:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581498587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+N93uBl2d+oxlCc3zfqgWXjrWri8/UpXlcvxr7fNw84=; b=SAAtBd26PylFD6Bu11q2rYKf4Qm+TnF4dLg04viqjE3vg2CsE2KCJ+2/od+HzZXQUGPI90 iUNi7yc6nCYsZgTmND0I+yJhS6LtbuGU/QoPtRcvQLjBvUBYyqt8NqiieFNjfSTKIIvPcb Mycn0968lOqnT5NYUInCCMTZjDoUq8M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-1ArEa8opPNCYXvlr5ogMYQ-1; Wed, 12 Feb 2020 04:09:43 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3B121005513; Wed, 12 Feb 2020 09:09:41 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A3D05C1B0; Wed, 12 Feb 2020 09:09:39 +0000 (UTC) Message-ID: <9560dbbed0d73e5dc1c3e0fb2f2a687155f9a962.camel@redhat.com> Subject: Re: [PATCH v5 02/26] nvme: remove superfluous breaks From: Maxim Levitsky To: Klaus Jensen , qemu-block@nongnu.org Date: Wed, 12 Feb 2020 11:09:28 +0200 In-Reply-To: <20200204095208.269131-3-k.jensen@samsung.com> References: <20200204095208.269131-1-k.jensen@samsung.com> <20200204095208.269131-3-k.jensen@samsung.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 1ArEa8opPNCYXvlr5ogMYQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Beata Michalska , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Klaus Jensen , Javier Gonzalez Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > These break statements was left over when commit 3036a626e9ef ("nvme: > add Get/Set Feature Timestamp support") was merged. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index dd548d9b6605..c9ad6aaa5f95 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -788,7 +788,6 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeCmd *cmd, NvmeRequest *req) > break; > case NVME_TIMESTAMP: > return nvme_get_feature_timestamp(n, cmd); > - break; > default: > trace_nvme_dev_err_invalid_getfeat(dw10); > return NVME_INVALID_FIELD | NVME_DNR; > @@ -831,11 +830,8 @@ static uint16_t nvme_set_feature(NvmeCtrl *n, NvmeCmd *cmd, NvmeRequest *req) > req->cqe.result = > cpu_to_le32((n->num_queues - 2) | ((n->num_queues - 2) << 16)); > break; > - > case NVME_TIMESTAMP: > return nvme_set_feature_timestamp(n, cmd); > - break; > - > default: > trace_nvme_dev_err_invalid_setfeat(dw10); > return NVME_INVALID_FIELD | NVME_DNR; Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky