qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Weil <sw@weilnetz.de>,
	Howard Spoelstra <hsp.cat7@gmail.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tap-win32: correctly recycle buffers
Date: Thu, 1 Apr 2021 15:23:29 +0800	[thread overview]
Message-ID: <956b1e90-e9a6-19fc-8e21-521504fa7307@redhat.com> (raw)
In-Reply-To: <CAEUhbmUciCL-kiikmTyR172kZ2A0D-nz+gsEXkwP_MneGsu=SA@mail.gmail.com>


在 2021/3/29 上午11:01, Bin Meng 写道:
> On Mon, Mar 29, 2021 at 10:20 AM Jason Wang <jasowang@redhat.com> wrote:
>> Commit 969e50b61a28 ("net: Pad short frames to minimum size before
>> sending from SLiRP/TAP") tries to pad frames but try to recyle the
>> local array that is used for padding to tap thread. This patch fixes
>> this by recyling the original buffer.
>>
>> Fixes: 969e50b61a28 ("net: Pad short frames to minimum size before sending from SLiRP/TAP")
>> Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>>   net/tap-win32.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Tested booting U-Boot with QEMU ppce500 on Windows, without the patch,
> QEMU crashes
> Tested-by: Bin Meng <bmeng.cn@gmail.com>
>

Applied.

Thanks



      reply	other threads:[~2021-04-01  7:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29  2:20 [PATCH] tap-win32: correctly recycle buffers Jason Wang
2021-03-29  3:01 ` Bin Meng
2021-04-01  7:23   ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=956b1e90-e9a6-19fc-8e21-521504fa7307@redhat.com \
    --to=jasowang@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=hsp.cat7@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).