Re: [PATCH] accel/kvm/kvm-all: Fix wrong return code handling in dirty log code

[Thomas Huth <thuth@redhat.com>]

On 29/01/2021 10.28, Philippe Mathieu-Daudé wrote:
> On 1/29/21 9:43 AM, Thomas Huth wrote:
>> The kvm_vm_ioctl() wrapper already returns -errno if the ioctl itself
>> returned -1, so the callers of kvm_vm_ioctl() should not check for -1
>> but for a value < 0 instead.
>>
>> This problem has been fixed once already in commit b533f658a98325d0e4
>> but that commit missed that the ENOENT error code is not fatal for
>> this ioctl, so the commit has been reverted in commit 50212d6346f33d6e
>> since the problem occurred close to a pending release at that point
>> in time. The plan was to fix it properly after the release, but it
>> seems like this has been forgotten. So let's do it now finally instead.
>>
>> Resolves: https://bugs.launchpad.net/qemu/+bug/1294227
> 
> Is this the "Close the oldest Launchpad bug" contest? =)

No, in that case I'd had tried to fix 
https://bugs.launchpad.net/qemu/+bug/304636 instead ;-)

> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks!

  Thomas