From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9591FC76196 for ; Tue, 28 Mar 2023 13:21:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ph9FX-0004RU-Sg; Tue, 28 Mar 2023 09:20:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph9FX-0004RL-2G for qemu-devel@nongnu.org; Tue, 28 Mar 2023 09:20:31 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ph9FV-0004iC-Hw for qemu-devel@nongnu.org; Tue, 28 Mar 2023 09:20:30 -0400 Received: by mail-wr1-x42f.google.com with SMTP id v1so12208052wrv.1 for ; Tue, 28 Mar 2023 06:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680009628; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dfSC/M0BU/ZV4g7hKlLFq19MVV6PyWXdVSz7CJwUwwo=; b=c0XQQCd6LdnKYn6ZniQisv5aLYDsqWV54iA8UjD+BDSjxjAw2cg+vDoqmcs2+4g7MJ 6AAjC49PSK1RyxR0YMeSPTKMty2fAcMe/WntGxh/K7Si03XSofBmuTr+K5gOKXIVN5Ch 1DHUiX6jjs5D6WDykZEuNLVd+XeXCil2M6rEsN70XhSQ+bjEO4es96EYAFnT5AhsYEK/ vpQc3gemVswonnFfpOHB9l8EtyIfsDAfVdrv8UVlC+ct4/qd9esOrgqWvABGR7KOk1KC qXIPhJ0716TjS77U6X4eTcki0EgjLFyzglpRhrNpiNgkcBdeBn7WdG71jGncmB/p/Edh ndBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680009628; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dfSC/M0BU/ZV4g7hKlLFq19MVV6PyWXdVSz7CJwUwwo=; b=hlp8Gpk2xyR//EarmJQm4pMxtKVPEI0jZOqWL3nOzPATvZP/kfPrNhppzTcB2JURXI xtGR1BCOHDFtBz+12aCLQ2ekOaURTQ5408LzKuJld6SXdxHObognXRkx2+yIcF/fTBu7 oruHCMJbSABO97HDeysZshQd3XQ1MJ6/J31XiwiZlNbhsQEaTvghy4JcVvgD0hPRFve+ bn2utWx0q89Yimqy2gOH2VJoz4tkXGoBgzge9SNIsEb/GkG0QvHeXIzRyA7dnPcwLIJP UOrnwV8lS397FwTn+vhdXmm0szclYBehGeGMl+4VZprLhA2uCBHJiWEOl41+bzxsHgjB 9VCg== X-Gm-Message-State: AAQBX9eVGuSn4XjLmgZJlFyEc1NtWN+0Us6OYipYv8YyBPCyuDqSdR3C sg1+ZQF/Vs5D4FcupPVg7Z9J0w== X-Google-Smtp-Source: AKy350ZCEwn1DXpBWPOdtDn8h3XLliwcP09TtA6U+RcFFZ1QQ3LLobP5b3AzRi0iV9QjzEqQjkKKsw== X-Received: by 2002:adf:e309:0:b0:2c7:f56:285b with SMTP id b9-20020adfe309000000b002c70f56285bmr12083247wrj.63.1680009627641; Tue, 28 Mar 2023 06:20:27 -0700 (PDT) Received: from [192.168.69.115] ([176.187.210.212]) by smtp.gmail.com with ESMTPSA id s15-20020a5d6a8f000000b002d743eeab39sm20871374wru.58.2023.03.28.06.20.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 06:20:27 -0700 (PDT) Message-ID: <958c4810-e351-04e4-42f4-d1bc86d303ad@linaro.org> Date: Tue, 28 Mar 2023 15:20:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled Content-Language: en-US To: Peter Maydell Cc: qemu-devel@nongnu.org, Richard Henderson , Fabiano Rosas , Claudio Fontana , qemu-arm@nongnu.org References: <20230322142902.69511-1-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 28/3/23 11:54, Peter Maydell wrote: > On Wed, 22 Mar 2023 at 14:29, Philippe Mathieu-Daudé wrote: >> >> Fix when building QEMU configured with --disable-tcg: >> >> Undefined symbols for architecture arm64: >> "_arm_v7m_get_sp_ptr", referenced from: >> _m_sysreg_get in target_arm_gdbstub.c.o >> "_arm_v7m_mrs_control", referenced from: >> _arm_gdb_get_m_systemreg in target_arm_gdbstub.c.o >> "_pauth_ptr_mask", referenced from: >> _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o >> ld: symbol(s) not found for architecture arm64 >> clang: error: linker command failed with exit code 1 (use -v to see invocation) >> >> Philippe Mathieu-Daudé (2): >> target/arm/gdbstub: Restrict aarch64_gdb_get_pauth_reg() to CONFIG_TCG >> target/arm/gdbstub: Only advertise M-profile features if TCG available > > I've applied patch 2 to target-arm.next; thanks. If you only take #2, then you need to squash this from #1: -- >8 -- diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c @@ -21,6 +21,7 @@ #include "cpu.h" #include "exec/gdbstub.h" #include "gdbstub/helpers.h" +#include "sysemu/tcg.h" #include "internals.h" #include "cpregs.h" --- I can respin if it eases your workflow. Thanks, Phil.