From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>, cohuck@redhat.com
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/3] s390x/sclp: extend SCLP event masks to 64 bits
Date: Fri, 23 Feb 2018 15:44:48 +0100 [thread overview]
Message-ID: <95b90dd7-82aa-bc7f-896b-88aed8f9ee80@de.ibm.com> (raw)
In-Reply-To: <1519390265-15576-4-git-send-email-imbrenda@linux.vnet.ibm.com>
On 02/23/2018 01:51 PM, Claudio Imbrenda wrote:
>
> +static bool vmstate_event_facility_mask64_needed(void *opaque)
> +{
> + SCLPEventFacility *ef = opaque;
> +
> + return (ef->receive_mask & 0xFFFFFFFF) != 0;
> +}
> +
> +static int vmstate_event_facility_mask64_pre_load(void *opaque)
> +{
> + SCLPEventFacility *ef = opaque;
> +
> + ef->receive_mask &= ~0xFFFFFFFFULL;
> + return 0;
> +}
again, no need for a pre-load here. The ef->receive_mask should start out as 0.
next prev parent reply other threads:[~2018-02-23 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 12:51 [Qemu-devel] [PATCH v3 0/3] s390x/sclp: 64 bit event masks Claudio Imbrenda
2018-02-23 12:51 ` [Qemu-devel] [PATCH v3 1/3] s390x/sclp: proper support of larger send and receive masks Claudio Imbrenda
2018-02-23 14:27 ` Christian Borntraeger
2018-02-23 15:13 ` Claudio Imbrenda
2018-02-23 12:51 ` [Qemu-devel] [PATCH v3 2/3] s390x/sclp: clean up sclp masks Claudio Imbrenda
2018-02-23 14:30 ` Christian Borntraeger
2018-02-23 12:51 ` [Qemu-devel] [PATCH v3 3/3] s390x/sclp: extend SCLP event masks to 64 bits Claudio Imbrenda
2018-02-23 14:44 ` Christian Borntraeger [this message]
2018-02-23 13:02 ` [Qemu-devel] [PATCH v3 0/3] s390x/sclp: 64 bit event masks Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95b90dd7-82aa-bc7f-896b-88aed8f9ee80@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).