From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D5FFC63697 for ; Sat, 28 Nov 2020 07:07:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF2A022275 for ; Sat, 28 Nov 2020 07:07:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF2A022275 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiuKV-0002V1-PK for qemu-devel@archiver.kernel.org; Sat, 28 Nov 2020 02:07:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiuJ9-0001Kb-Rl for qemu-devel@nongnu.org; Sat, 28 Nov 2020 02:06:11 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiuJ7-0006cD-RK for qemu-devel@nongnu.org; Sat, 28 Nov 2020 02:06:11 -0500 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4CjjF141bkzVjDr; Sat, 28 Nov 2020 15:05:25 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sat, 28 Nov 2020 15:06:05 +0800 Received: from [10.174.187.211] (10.174.187.211) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Sat, 28 Nov 2020 15:06:04 +0800 Subject: Re: [RFC PATCH 4/6] migration: Add zstd support in multi-thread compression To: Markus Armbruster References: <20201127074209.2217-1-jinzeyu@huawei.com> <87lfenq9u0.fsf@dusky.pond.sub.org> From: Zeyu Jin Message-ID: <95dc00fb-e96d-e7d1-0829-b7d75f0ba64b@huawei.com> Date: Sat, 28 Nov 2020 15:06:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87lfenq9u0.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.211] X-ClientProxiedBy: dggemi704-chm.china.huawei.com (10.3.20.103) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.187; envelope-from=jinzeyu@huawei.com; helo=szxga01-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ying Fang , zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/11/27 20:10, Markus Armbruster wrote: > Zeyu Jin writes: > >> This patch enables zstd option in multi-thread compression. >> >> Signed-off-by: Zeyu Jin >> Signed-off-by: Ying Fang > [...] >> diff --git a/qapi/migration.json b/qapi/migration.json >> index d262683a38..ac6d06c683 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -536,7 +536,7 @@ >> # >> ## >> { 'enum': 'CompressMethod', >> - 'data': [ 'zlib' ] } >> + 'data': [ 'zlib', { 'name': 'zstd', 'if': 'defined(CONFIG_ZSTD)' } ] } >> >> ## >> # @BitmapMigrationBitmapAlias: > > Please document the new enum value @zstd. I will document that. Thank you. > > . >