From: Paolo Bonzini <pbonzini@redhat.com>
To: "BALATON Zoltan" <balaton@eik.bme.hu>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: jan.kiszka@siemens.com,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel <qemu-devel@nongnu.org>,
cota@braap.org, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
bobby.prani@gmail.com, rth@twiddle.net,
fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"
Date: Thu, 16 Mar 2017 07:39:43 +0100 [thread overview]
Message-ID: <95e306ce-8b80-f3c7-c374-85def4f549ff@redhat.com> (raw)
In-Reply-To: <alpine.BSF.2.20.1703141829440.39248@zero.eik.bme.hu>
On 14/03/2017 18:34, BALATON Zoltan wrote:
> Like from the display controller models that use
> memory_region_get_dirty() to check if the frambuffer needs to be
> updated? But all display adaptors seem to do this and the problem was
> only seem on ppc so it may be related to something ppc specific.
You need to use test_and_clear_dirty instead of get_dirty/reset_dirty.
Or alternatively you need to reset immediately after get_dirty. At
least cg3.c is doing
read dirty bitmap
read VRAM
clear dirty bitmap
which has a race.
Paolo
next prev parent reply other threads:[~2017-03-16 6:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <36e41adf-b0b3-3efa-51c4-f1a70cd05b98@ilande.co.uk>
2017-03-13 21:28 ` [Qemu-devel] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution" Mark Cave-Ayland
[not found] ` <87wpbsp49a.fsf@linaro.org>
2017-03-14 11:12 ` Mark Cave-Ayland
2017-03-14 13:56 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2017-03-14 15:02 ` luigi burdo
2017-03-14 15:41 ` Alex Bennée
2017-03-14 15:52 ` Mark Cave-Ayland
2017-03-14 16:48 ` Alex Bennée
2017-03-14 17:34 ` BALATON Zoltan
2017-03-14 17:53 ` luigi burdo
2017-03-15 11:14 ` Alex Bennée
2017-03-15 13:26 ` Mark Cave-Ayland
2017-03-15 14:19 ` Alex Bennée
2017-03-16 6:39 ` Paolo Bonzini [this message]
2017-03-16 7:51 ` Alex Bennée
2017-03-16 8:34 ` Paolo Bonzini
2017-03-16 15:34 ` Gerd Hoffmann
2017-03-16 17:00 ` Paolo Bonzini
2017-03-28 13:40 ` Gerd Hoffmann
2017-03-28 14:13 ` Paolo Bonzini
2017-03-15 14:16 ` Alex Bennée
2017-03-15 15:25 ` Gerd Hoffmann
2017-03-15 16:20 ` Alex Bennée
2017-03-16 7:35 ` Gerd Hoffmann
2017-03-16 7:56 ` Alex Bennée
2017-03-16 14:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e306ce-8b80-f3c7-c374-85def4f549ff@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=bobby.prani@gmail.com \
--cc=cota@braap.org \
--cc=fred.konrad@greensocs.com \
--cc=jan.kiszka@siemens.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).