qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/m68k: implement fmove.l #<data>,FPCR
Date: Sun, 31 May 2020 13:23:38 +0200	[thread overview]
Message-ID: <96042cba-c58b-576e-b34e-e30a817234e3@physik.fu-berlin.de> (raw)
In-Reply-To: <20200531110231.620711-1-laurent@vivier.eu>

Hi Laurent!

On 5/31/20 1:02 PM, Laurent Vivier wrote:
> The immediate value mode was ignored and instruction execution
> ends to an invalid access mode.
> 
> This was found running 'R' that set FPSR to 0 at startup with
> a 'fmove.l #0,FPSR' in qemu-system-m68k emulation and triggers a
> kernel crash:
> (...)
> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  target/m68k/translate.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
Thanks for the fix.

I applied the patch, but I'm getting a lock-up now as you previously reported
in the other discussion on the Linux/m68k mailing list:

root@pacman:~# R
[   68.420000] watchdog: BUG: soft lockup - CPU#0 stuck for 22s! [R:650]
[   68.420000] Modules linked in: sg evdev mac_hid ip_tables x_tables sha1_generic hmac ipv6 nf_defrag_ipv6 autofs4 ext4 crc16 mbcache jbd2 crc32c_generic sd_mod t10_pi crc_t10dif sr_mod cdrom crct10dif_generic crct10dif_common mac_esp macsonic esp_scsi
[   68.420000] Format 00  Vector: 0064  PC: 0002df9c  Status: 2008    Not tainted
[   68.420000] ORIG_D0: ffffffff  D0: 00000000  A2: c02e239a  A1: ffa10000
[   68.420000] A0: 3c9adf29  D5: 0000000d  D4: 8002ce30
[   68.420000] D3: 8002b418  D2: 8002b4b4  D1: 00000000

Is this related or a different bug?

I have not seen these lockups on real hardware.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


  reply	other threads:[~2020-05-31 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 11:02 [PATCH] target/m68k: implement fmove.l #<data>,FPCR Laurent Vivier
2020-05-31 11:23 ` John Paul Adrian Glaubitz [this message]
2020-05-31 12:09   ` Laurent Vivier
2020-05-31 13:15     ` John Paul Adrian Glaubitz
2020-06-01 22:15 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96042cba-c58b-576e-b34e-e30a817234e3@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).