From: Zhang Yi <yi.z.zhang@linux.intel.com>
To: xiaoguangrong.eric@gmail.com, dan.j.williams@intel.com,
stefanha@redhat.com, pbonzini@redhat.com,
yu.c.zhang@linux.intel.com
Cc: mst@redhat.com, qemu-devel@nongnu.org, imammedo@redhat.com,
ehabkost@redhat.com, Zhang Yi <yi.z.zhang@linux.intel.com>
Subject: [Qemu-devel] [PATCH V5_resend 3/7] exec: switch qemu_ram_alloc_from_{file, fd} to the 'flags' parameter
Date: Tue, 20 Nov 2018 15:48:22 +0800 [thread overview]
Message-ID: <9619c036a6dc6cb4966f46d2405084f11666e14d.1542699775.git.yi.z.zhang@linux.intel.com> (raw)
In-Reply-To: <cover.1542699775.git.yi.z.zhang@linux.intel.com>
As more flag parameters besides the existing 'share' are going to be
added to qemu_ram_alloc_from_{file,fd}(), let's swith 'share' to a
'flags' parameters in advance, so as to ease the further additions.
Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
---
exec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index 273f668..e92a7da 100644
--- a/exec.c
+++ b/exec.c
@@ -1810,6 +1810,7 @@ static void *file_ram_alloc(RAMBlock *block,
ram_addr_t memory,
int fd,
bool truncate,
+ uint32_t flags,
Error **errp)
{
void *area;
@@ -1859,7 +1860,7 @@ static void *file_ram_alloc(RAMBlock *block,
perror("ftruncate");
}
- area = qemu_ram_mmap(fd, memory, block->mr->align, block->flags);
+ area = qemu_ram_mmap(fd, memory, block->mr->align, flags);
if (area == MAP_FAILED) {
error_setg_errno(errp, errno,
"unable to map backing store for guest RAM");
@@ -2278,7 +2279,8 @@ RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr,
new_block->used_length = size;
new_block->max_length = size;
new_block->flags = ram_flags;
- new_block->host = file_ram_alloc(new_block, size, fd, !file_size, errp);
+ new_block->host = file_ram_alloc(new_block, size, fd, !file_size,
+ ram_flags, errp);
if (!new_block->host) {
g_free(new_block);
return NULL;
--
2.7.4
next prev parent reply other threads:[~2018-11-20 7:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 7:47 [Qemu-devel] [PATCH V5_resend 0/7] nvdimm: support MAP_SYNC for memory-backend-file Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message Zhang Yi
2018-11-26 13:10 ` Igor Mammedov
2018-11-29 8:41 ` Pankaj Gupta
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 2/7] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter Zhang Yi
2018-11-20 7:48 ` Zhang Yi [this message]
2018-11-29 9:11 ` [Qemu-devel] [PATCH V5_resend 3/7] exec: switch qemu_ram_alloc_from_{file, fd} to the " Pankaj Gupta
2018-12-04 7:28 ` Yi Zhang
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 4/7] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 6/7] hostmem: add more information in error messages Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 7/7] hostmem-file: add 'sync' option Zhang Yi
2018-11-26 8:46 ` Pankaj Gupta
2018-12-04 7:32 ` Yi Zhang
2018-11-26 3:00 ` [Qemu-devel] [PATCH V5_resend 0/7] nvdimm: support MAP_SYNC for memory-backend-file Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9619c036a6dc6cb4966f46d2405084f11666e14d.1542699775.git.yi.z.zhang@linux.intel.com \
--to=yi.z.zhang@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).